chore: very very minor sv additions

Author: bransfl

Addictol/Source/Modules/AdModuleDpiScaling.cpp

@@ -69,15 +69,15 @@ namespace Addictol
 
 	bool ModuleDpiScaling::DoInstall([[maybe_unused]] F4SE::MessagingInterface::Message* a_msg) noexcept
 	{
-		const char* level = nullptr;
+		std::string level = "";
 		if (detail::TrySetPerMonitorV2())
-			level = "PER_MONITOR_AWARE_V2";
+			level = "PER_MONITOR_AWARE_V2"sv;
 		else if (detail::TrySetPerMonitor())
-			level = "PROCESS_PER_MONITOR_DPI_AWARE";
+			level = "PROCESS_PER_MONITOR_DPI_AWARE"sv;
 		else if (detail::TrySetDpiAware())
-			level = "DPI_AWARE";
+			level = "DPI_AWARE"sv;
 
-		if (level)
+		if (!level.empty())
 			REX::INFO("DPI Scaling: applied {}"sv, level);
 		else
 			REX::WARN("DPI Scaling: no SetProcessDpi* entry point accepted; process remains DPI-unaware"sv);

Addictol/Source/Modules/AdModulePipBoyCursorConstraints.cpp

@@ -43,14 +43,14 @@ namespace Addictol
 		static REL::Relocation<std::uint32_t*> PipboyConstraintWidth_PowerArmor{ RE::ID::MenuCursor::PipboyConstraintWidth_PowerArmor };
 		static REL::Relocation<std::uint32_t*> PipboyConstraintHeight_PowerArmor{ RE::ID::MenuCursor::PipboyConstraintHeight_PowerArmor };
 
-		inline void LogPipBoyConstraints(std::string a_title, std::uint32_t a_tlx, std::uint32_t a_tly, std::uint32_t a_width, std::uint32_t a_height) noexcept
+		inline void LogPipBoyConstraints(std::string_view a_title, std::uint32_t a_tlx, std::uint32_t a_tly, std::uint32_t a_width, std::uint32_t a_height) noexcept
 		{
 #if !AD_NOMESSAGE_PIPBOY_CURSOR_CONSTRAINTS
-			REX::INFO("{}", a_title);
-			REX::INFO("TLX: {}", a_tlx);
-			REX::INFO("TLY: {}", a_tly);
-			REX::INFO("Width: {}", a_width);
-			REX::INFO("Height: {}", a_height);
+			REX::INFO("{}"sv, a_title);
+			REX::INFO("TLX: {}"sv, a_tlx);
+			REX::INFO("TLY: {}"sv, a_tly);
+			REX::INFO("Width: {}"sv, a_width);
+			REX::INFO("Height: {}"sv, a_height);
 #endif
 		}
 
@@ -67,13 +67,13 @@ namespace Addictol
 			// Fail if we couldn't get the Settings
 			if (!uPipboyTargetWidth || !uPipboyTargetHeight)
 			{
-				REX::WARN("Could not get one of the uPipboyTargetWidth/Height settings!");
+				REX::WARN("Could not get one of the uPipboyTargetWidth/Height settings!"sv);
 				return false;
 			}
 
 #if !AD_NOMESSAGE_PIPBOY_CURSOR_CONSTRAINTS
 			// Log PipBoy Resolution
-			REX::INFO("PipBoy Resolution: {}x{}", uPipboyTargetWidth->GetUInt(), uPipboyTargetHeight->GetUInt());
+			REX::INFO("PipBoy Resolution: {}x{}"sv, uPipboyTargetWidth->GetUInt(), uPipboyTargetHeight->GetUInt());
 #endif
 
 			return true;
@@ -90,8 +90,8 @@ namespace Addictol
 			const float heightFactor = (float)uPipboyTargetHeight->GetUInt() / defaultPipboyTargetHeight;
 
 			// Log before updating PipBoy Constraints
-			LogPipBoyConstraints("PipBoy Constraints Pre-Update:", *PipboyConstraintTLX, *PipboyConstraintTLY, *PipboyConstraintWidth, *PipboyConstraintHeight);
-			LogPipBoyConstraints("PA PipBoy Constraints Pre-Update:", *PipboyConstraintTLX_PowerArmor, *PipboyConstraintTLY_PowerArmor, *PipboyConstraintWidth_PowerArmor, *PipboyConstraintHeight_PowerArmor);
+			LogPipBoyConstraints("PipBoy Constraints Pre-Update:"sv, *PipboyConstraintTLX, *PipboyConstraintTLY, *PipboyConstraintWidth, *PipboyConstraintHeight);
+			LogPipBoyConstraints("PA PipBoy Constraints Pre-Update:"sv, *PipboyConstraintTLX_PowerArmor, *PipboyConstraintTLY_PowerArmor, *PipboyConstraintWidth_PowerArmor, *PipboyConstraintHeight_PowerArmor);
 
 			// Update PipBoy Constraints
 			*PipboyConstraintTLX 	= static_cast<std::uint32_t>(std::ceil(defaultPipboyConstraintTLX * widthFactor));
@@ -106,8 +106,8 @@ namespace Addictol
 			*PipboyConstraintHeight_PowerArmor 	= static_cast<std::uint32_t>(std::ceil(defaultPipboyConstraintHeight_PowerArmor * heightFactor));
 
 			// Log after updating PipBoy Constraints
-			LogPipBoyConstraints("PipBoy Constraints Post-Update:", *PipboyConstraintTLX, *PipboyConstraintTLY, *PipboyConstraintWidth, *PipboyConstraintHeight);
-			LogPipBoyConstraints("PA PipBoy Constraints Post-Update:", *PipboyConstraintTLX_PowerArmor, *PipboyConstraintTLY_PowerArmor, *PipboyConstraintWidth_PowerArmor, *PipboyConstraintHeight_PowerArmor);
+			LogPipBoyConstraints("PipBoy Constraints Post-Update:"sv, *PipboyConstraintTLX, *PipboyConstraintTLY, *PipboyConstraintWidth, *PipboyConstraintHeight);
+			LogPipBoyConstraints("PA PipBoy Constraints Post-Update:"sv, *PipboyConstraintTLX_PowerArmor, *PipboyConstraintTLY_PowerArmor, *PipboyConstraintWidth_PowerArmor, *PipboyConstraintHeight_PowerArmor);
 
 			return true;
 		}

Addictol/Source/Modules/AdModuleToggleGrassCommand.cpp

@@ -19,7 +19,7 @@ namespace Addictol
 
 	bool ModuleToggleGrassCommand::DoInstall([[maybe_unused]] F4SE::MessagingInterface::Message* a_msg) noexcept
 	{
-		RE::SCRIPT_FUNCTION* consoleCommand = RE::SCRIPT_FUNCTION::LocateConsoleCommand("ToggleGrass");
+		RE::SCRIPT_FUNCTION* consoleCommand = RE::SCRIPT_FUNCTION::LocateConsoleCommand("ToggleGrass"sv);
 		if (consoleCommand)
 		{
 			bool isReferenceFunction = false;