fix(animated-static-reload): walk sequenceArray to avoid anim-thread race

NiControllerManager::activeSequences is mutated per-frame by the animation
worker thread. HookShouldSaveAnimationOnSaving was reading it from the save
thread with no lock, corrupting the engine's BSTScatterTable and tripping
the "Scatter table has been trashed" assert mid-save.

Walk the owned sequenceArray instead (populated only on AddSequence /
RemoveSequence during model setup and teardown) with a small sanity bound
on count and capacity. Per-sequence state and cycleType are 32-bit aligned
reads so an unlocked walk at worst flips one ref's verdict.

Split the hook into DoCheck plus a SafeCheck SEH shim so the GFx/Ni locals
do not collide with __try (C2712).

Author: northaxosky

Addictol/Source/Modules/AdModuleAnimatedStaticReload.cpp

@@ -2,7 +2,6 @@
 #include <AdUtils.h>
 
 #include <RE/B/BGSMovableStatic.h>
-#include <RE/B/BSTArray.h>
 #include <RE/N/NiAVObject.h>
 #include <RE/N/NiControllerManager.h>
 #include <RE/N/NiControllerSequence.h>
@@ -29,30 +28,25 @@ namespace Addictol
 		using TShouldSave = bool(__fastcall*)(const RE::TESObjectREFR*);
 		static TShouldSave OriginalShouldSave = nullptr;
 
-		using ActiveSequences = RE::BSTArray<RE::NiPointer<RE::NiControllerSequence>>;
-
 		[[nodiscard]] static CycleType GetCycleType(const RE::NiControllerSequence* a_seq) noexcept
 		{
 			return *reinterpret_cast<const CycleType*>(a_seq->cycleType);
 		}
 
-		[[nodiscard]] static const ActiveSequences* GetActiveSequences(const RE::NiControllerManager* a_mgr) noexcept
-		{
-			if (!a_mgr)
-				return nullptr;
-			return reinterpret_cast<const ActiveSequences*>(a_mgr->activeSequences);
-		}
-
-		[[nodiscard]] static bool HasLoopingActiveSequence(const RE::NiAVObject* a_root) noexcept
+		// activeSequences gets stomped by the anim thread every frame. Walk sequenceArray instead.
+		[[nodiscard]] static bool HasLoopingSequence(const RE::NiAVObject* a_root) noexcept
 		{
 			if (!a_root)
 				return false;
 			auto* mgr = RE::NiControllerManager::GetNiControllerManager(a_root);
-			const auto* sequences = GetActiveSequences(mgr);
-			if (!sequences)
+			if (!mgr)
+				return false;
+			const auto count    = mgr->sequenceArray.size();
+			const auto capacity = mgr->sequenceArray.capacity();
+			if (count == 0 || count > capacity || capacity > 1024 || !mgr->sequenceArray.data())
 				return false;
-			for (const auto& seq : *sequences) {
-				const auto* raw = seq.get();
+			for (std::uint32_t i = 0; i < count; ++i) {
+				const auto* raw = mgr->sequenceArray[i].get();
 				if (!raw)
 					continue;
 				if (raw->state == RE::NiControllerSequence::AnimState::kAnimating &&
@@ -62,22 +56,33 @@ namespace Addictol
 			return false;
 		}
 
-		static bool __fastcall HookShouldSaveAnimationOnSaving(const RE::TESObjectREFR* a_ref) noexcept
+		static bool DoCheck(const RE::TESObjectREFR* a_ref) noexcept
 		{
-			const bool original = OriginalShouldSave ? OriginalShouldSave(a_ref) : false;
-			if (original || !a_ref)
-				return original;
+			const auto* base = a_ref->GetObjectReference();
+			if (!base || !base->As<RE::BGSMovableStatic>())
+				return false;
+			return HasLoopingSequence(a_ref->Get3D());
+		}
 
+		// DoCheck has GFx/Ni locals, so the __try has to live up here (C2712).
+		static bool SafeCheck(const RE::TESObjectREFR* a_ref) noexcept
+		{
 			__try {
-				const auto* base = a_ref->GetObjectReference();
-				if (!base || !base->As<RE::BGSMovableStatic>())
-					return false;
-				return HasLoopingActiveSequence(a_ref->Get3D());
+				return DoCheck(a_ref);
 			}
 			__except (1) {
-				return original;
+				return false;
 			}
 		}
+
+		static bool __fastcall HookShouldSaveAnimationOnSaving(const RE::TESObjectREFR* a_ref) noexcept
+		{
+			const bool original = OriginalShouldSave ? OriginalShouldSave(a_ref) : false;
+			if (original || !a_ref)
+				return original;
+
+			return SafeCheck(a_ref);
+		}
 	}
 
 	ModuleAnimatedStaticReload::ModuleAnimatedStaticReload() :