fix(alttab-fullscreen): patch SetFullscreenState to actually keep us windowed#28
Merged
Merged
Conversation
MakeWindowAssociation only catches DXGI's auto alt-enter; explicit calls bypassed it. Vtable-hook slot 10 on the returned swap chain, scoped to the game HWND so other mods' swap chains forward untouched.
northaxosky
force-pushed
the
hotfix/alttab-fullscreen-setfullscreen-block
branch
from
d66c4e5 to
5c7e224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Vtable-hook slot 10 (
SetFullscreenState) on theIDXGISwapChainreturned fromD3D11CreateDeviceAndSwapChain.a_fullscreen == TRUEcalls on the game's HWND are short-circuited toS_OKwithout forwarding. Everything else forwards untouched.Details
OriginalSetFullscreenStateis published tostd::atomicbefore callingDetourVTable, so a thread that catches the patched vtable never sees a null original.compare_exchange_strong; rolls back on failure.MakeWindowAssociationHRESULT now logged on failure (was silently swallowed).Windowed=TRUErewrite andMakeWindowAssociationcalls preserved as belt-and-suspenders.