fix(animated-static-reload): remove module#29
Merged
Conversation
FO4 vanilla ShouldSaveAnimationOnSaving already saves animated loops with non-default names via its out3 branch, so the additive force-true made MovableStatic saves wider than the engine intends. perchik bisected a save/load Creations plugin-mismatch dialog to this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FO4 vanilla ShouldSaveAnimationOnSaving (slot 0x9D) already saves animated loops with non-default names via its
out3branch, so the additive force-true on MovableStatic refs was widening saves beyond the engine's intent. perchik bisected a save/load Creations plugin-mismatch dialog to this module.Upstream lineage (Maxsu/doodlum on Skyrim) is dormant and was never picked up by aers' EngineFixesSkyrim64. In FO4 the vanilla predicate is broader than Skyrim's, so the port was redundant for the cases users actually care about (windmills, fans, generators, etc., all of which use non-Idle sequence names and already hit
out3).