🐛 Correct Y-coordinate calculation for clickable entities.#397
Open
Zoriot wants to merge 1 commit into
Open
Conversation
According to my extensive testing, offsetting it by +0.5, as was done previously, causes it to resemble a passenger and places it directly above the other armour stand. This makes the hitbox for actions uncomfortable at the top. Currently, I am not aware of a way to change this. This commit changes it to the same height as the text itself and works for down origin HGs and normal ones. This is important for a good user experience. The armour stands are still not in the same positions, so the hitbox starts at the text and goes above it. In the long term, another idea would be to use the same entity as the text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to my extensive testing on Paper 1.21.11, offsetting it by +0.5, as was done previously, causes it to resemble a passenger and places it directly above the other armour stand. This makes the hitbox for actions uncomfortable at the top. Currently, I am not aware of a way to change this.
This commit changes it to the same height as the text itself and works for down origin HGs and normal ones. This is important for a good user experience. The armour stands are still not in the same positions, so the hitbox starts at the text and goes above it. In the long term, another idea would be to use the same entity as the text.
This change isn't needed on all setups and in some it makes it actually behaving worse.