Do not fail in case of moved file#1439
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit to mitigate Issue #1436
lambdapi install moves .lp and .lpo files into the standard lib_root; moreover when "lambdapi build" is called from opam, the files are also moved to yet another location (inside the sandbox) to compile them.
However, the .lpo are NOT relocatable in the sense that filenames inside positions
posare absolute path. We use them:a) during indexing of rules to build a
qualidfor the ruleb) to open the file to show the result of queries
Both use cases (a and b) used to fail. In particular, a) prevented to import a library from the standard
lib_root.As a mitigation, we replace the hard failures with degradation of functionality. Further work will be necessary to restore the full functionality. In particular, libraries installed in stdlib_root should always be globally indexed.