Apply suggestions from code review

Co-authored-by: Robert Resch <robert@resch.dev>

Author: nanomad

deebot_client/events/fan_speed.py

@@ -15,10 +15,10 @@ class FanSpeedLevel(IntEnumWithXml):
     """Enum class for all possible fan speed levels."""
 
     # Values should be sort from low to high on their meanings
-    QUIET = 1000, ""
+    QUIET = 1000
     NORMAL = 0, "standard"
     MAX = 1, "strong"
-    MAX_PLUS = 2, ""
+    MAX_PLUS = 2
 
 
 @dataclass(frozen=True)

deebot_client/util/enum.py

@@ -9,21 +9,22 @@
 class StrEnumWithXml(StrEnum):
     """String enum with xml value."""
 
-    xml_value: str
+    xml_value: str | None
 
-    def __new__(cls, value: str, xml_value: str = "") -> Self:
+    def __new__(cls, value: str, xml_value: str | None = None) -> Self:
         """Create new StrEnumWithXml."""
         obj = str.__new__(cls, value)
         obj._value_ = value
         obj.xml_value = xml_value
         return obj
 
     @classmethod
-    def from_xml(cls, value: str) -> Self:
+    def from_xml(cls, value: str | None) -> Self:
         """Convert from xml value."""
-        for member in cls:
-            if member.xml_value == value:
-                return member
+        if value:
+            for member in cls:
+                if member.xml_value == value:
+                    return member
 
         msg = f"{value} is not a valid {cls.__name__}"
         raise ValueError(msg)
@@ -32,21 +33,22 @@ def from_xml(cls, value: str) -> Self:
 class IntEnumWithXml(IntEnum):
     """Int enum with xml value."""
 
-    xml_value: str
+    xml_value: str | None
 
-    def __new__(cls, value: int, xml_value: str = "") -> Self:
+    def __new__(cls, value: int, xml_value: str | None = None) -> Self:
         """Create new StrEnumWithXml."""
         obj = int.__new__(cls, value)
         obj._value_ = value
         obj.xml_value = xml_value
         return obj
 
     @classmethod
-    def from_xml(cls, value: str) -> Self:
+    def from_xml(cls, value: str | None) -> Self:
         """Convert from xml value."""
-        for member in cls:
-            if member.xml_value == value:
-                return member
+        if value:
+            for member in cls:
+                if member.xml_value == value:
+                    return member
 
         msg = f"{value} is not a valid {cls.__name__}"
         raise ValueError(msg)

tests/events/test_fan_speed.py

@@ -5,9 +5,7 @@
 from deebot_client.events import FanSpeedLevel
 
 
-@pytest.mark.parametrize(
-    "value", [level for level in FanSpeedLevel if level.xml_value != ""]
-)
+@pytest.mark.parametrize("value", [level for level in FanSpeedLevel if level.xml_value])
 def test_clean_action_xml_conversion(value: FanSpeedLevel) -> None:
     assert FanSpeedLevel.from_xml(value.xml_value) == value