Add missing test cases

Author: nanomad

deebot_client/commands/xml/clean.py

@@ -91,7 +91,7 @@ def _handle_xml(cls, event_bus: EventBus, xml: Element) -> HandlingResult:
                 event_bus.notify(StateEvent(State.CLEANING))
             elif clean_action == CleanAction.PAUSE:
                 event_bus.notify(StateEvent(State.PAUSED))
-            else:
-                _LOGGER.debug("Ignored CleanState %s", clean_action)
+            elif clean_action in (CleanAction.RESUME, CleanAction.STOP):
+                event_bus.notify(StateEvent(State.IDLE))
 
         return HandlingResult.success()

tests/commands/xml/test_clean.py

@@ -3,16 +3,29 @@
 import pytest
 
 from deebot_client.command import CommandResult
-from deebot_client.commands.xml import GetCleanState
-from deebot_client.commands.xml.clean import CleanArea
+from deebot_client.commands.xml import Clean, CleanArea, GetCleanState
 from deebot_client.events import FanSpeedEvent, FanSpeedLevel, StateEvent
 from deebot_client.message import HandlingState
-from deebot_client.models import CleanMode, State
+from deebot_client.models import CleanAction, CleanMode, State
 from tests.commands import assert_command
 
 from . import get_request_xml
 
 
+@pytest.mark.parametrize(
+    ("command", "command_result"),
+    [
+        (Clean(CleanAction.START, speed=FanSpeedLevel.MAX), HandlingState.SUCCESS),
+        (Clean(CleanAction.PAUSE), HandlingState.SUCCESS),
+    ],
+)
+async def test_Clean(command: Clean, command_result: HandlingState) -> None:
+    json = get_request_xml("<ctl ret='ok'/>")
+    await assert_command(
+        command, json, None, command_result=CommandResult(command_result)
+    )
+
+
 @pytest.mark.parametrize(
     ("command", "command_result"),
     [
@@ -27,37 +40,51 @@ async def test_CleanArea(command: CleanArea, command_result: HandlingState) -> N
 
 
 @pytest.mark.parametrize(
-    ("speed", "state", "expected_fan_speed_event", "expected_state_event"),
+    ("speed", "action", "expected_fan_speed_event", "expected_state_event"),
     [
         (
-            "standard",
-            "s",
+            FanSpeedLevel.NORMAL,
+            CleanAction.START,
             FanSpeedEvent(FanSpeedLevel.NORMAL),
             StateEvent(State.CLEANING),
         ),
         (
-            "strong",
-            "s",
+            FanSpeedLevel.MAX,
+            CleanAction.START,
             FanSpeedEvent(FanSpeedLevel.MAX),
             StateEvent(State.CLEANING),
         ),
         (
-            "standard",
-            "p",
+            FanSpeedLevel.NORMAL,
+            CleanAction.PAUSE,
             FanSpeedEvent(FanSpeedLevel.NORMAL),
             StateEvent(State.PAUSED),
         ),
+        (
+            None,
+            CleanAction.RESUME,
+            None,
+            StateEvent(State.IDLE),
+        ),
+        (
+            None,
+            CleanAction.STOP,
+            None,
+            StateEvent(State.IDLE),
+        ),
     ],
-    ids=["standard_cleaning", "strong_cleaning", "paused"],
+    ids=["standard_cleaning", "strong_cleaning", "paused", "resume/idle", "stop/idle"],
 )
 async def test_get_clean_state(
-    speed: str,
-    state: str,
+    speed: FanSpeedLevel | None,
+    action: CleanAction | None,
     expected_fan_speed_event: FanSpeedEvent,
     expected_state_event: StateEvent,
 ) -> None:
+    speed_section = f"speed='{speed.xml_value}'" if speed is not None else ""
+    state_section = f"st='{action.xml_value}'" if action is not None else ""
     json = get_request_xml(
-        f"<ctl ret='ok'><clean type='auto' speed='{speed}' st='{state}' t='0' a='0' s='0' tr=''/></ctl>"
+        f"<ctl ret='ok'><clean type='auto' {speed_section} {state_section} t='0' a='0' s='0' tr=''/></ctl>"
     )
     await assert_command(
         GetCleanState(),