Skip to content

Add Deebot X5 PRO OMNI support#1473

Merged
edenhaus merged 2 commits into
DeebotUniverse:devfrom
genelee26:dev
May 6, 2026
Merged

Add Deebot X5 PRO OMNI support#1473
edenhaus merged 2 commits into
DeebotUniverse:devfrom
genelee26:dev

Conversation

@genelee26

Copy link
Copy Markdown
Contributor

Add support for DEEBOT X5 PRO OMNI, merge the "CapabilityWater" from X2 and base on the X8 Pro.

@edenhaus

Copy link
Copy Markdown
Member

Did you test this change?

@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.98%. Comparing base (4c3ecd6) to head (a5e5036).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1473      +/-   ##
==========================================
+ Coverage   94.95%   94.98%   +0.03%     
==========================================
  Files         157      158       +1     
  Lines        6144     6187      +43     
  Branches      350      350              
==========================================
+ Hits         5834     5877      +43     
  Misses        248      248              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@genelee26

Copy link
Copy Markdown
Contributor Author

Sorry for the late reply — I was on vacation and just got back to this.

Yes, I tested all of this on my physical Deebot X5 PRO OMNI device and verified sensor readings against the official Ecovacs app.

Testing process:

  1. Started with the X8 PRO definition as the base, since the X5 PRO OMNI shares most capabilities with it. Ran a full test of all capabilities — clean, charge, fan speed, map, life span, station, settings, stats, etc. All readings matched the app.

  2. During testing, I found that water_amount on the X5 PRO OMNI uses discrete levels (LOW/MEDIUM/HIGH) rather than a continuous slider like the X8 PRO. The level count matched the X2's implementation exactly.

  3. Merged CapabilityWater from the X2 definition, then re-tested the water module independently — water amount switching and mop_attached status both worked correctly and matched the app.

All capabilities defined in this PR have been verified on real hardware.

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @genelee26 👍

@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label May 6, 2026
@edenhaus edenhaus enabled auto-merge (squash) May 6, 2026 21:31
@codspeed-hq

codspeed-hq Bot commented May 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 113 untouched benchmarks


Comparing genelee26:dev (a5e5036) with dev (4c3ecd6)

Open in CodSpeed

@edenhaus edenhaus merged commit f3d5d58 into DeebotUniverse:dev May 6, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants