Add models by similarity#1495
Merged
Merged
Conversation
edenhaus
commented
Mar 25, 2026
Member
- 0jbd6s
- 62asng
- 6n9pcz
- 8n0t5d
- aasdks
- hu94nh
- kdnfi5
- rwp09o
- t5e5o6
- t6kipw
- u3bsxq
- va8ygm
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional hardware “model” entries by mapping new model IDs to existing implementations via similarity (aliasing).
Changes:
- Added 12 new
deebot_client.hardware.*modules corresponding to new model IDs. - Each new module appears to point to an existing model implementation (e.g.,
kd0una.py,9eamof.py).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deebot_client/hardware/va8ygm.py | Adds new model module pointing at 53qyvr.py |
| deebot_client/hardware/u3bsxq.py | Adds new model module pointing at kd0una.py |
| deebot_client/hardware/t6kipw.py | Adds new model module pointing at kd0una.py |
| deebot_client/hardware/t5e5o6.py | Adds new model module pointing at kd0una.py |
| deebot_client/hardware/rwp09o.py | Adds new model module pointing at kd0una.py |
| deebot_client/hardware/kdnfi5.py | Adds new model module pointing at 9eamof.py |
| deebot_client/hardware/hu94nh.py | Adds new model module pointing at 9eamof.py |
| deebot_client/hardware/aasdks.py | Adds new model module pointing at 9eamof.py |
| deebot_client/hardware/8n0t5d.py | Adds new model module pointing at 8o3xke.py |
| deebot_client/hardware/6n9pcz.py | Adds new model module pointing at 9bts2s.py |
| deebot_client/hardware/62asng.py | Adds new model module pointing at huhcip.py |
| deebot_client/hardware/0jbd6s.py | Adds new model module pointing at 2i0fns.py |
Comments suppressed due to low confidence (3)
deebot_client/hardware/u3bsxq.py:1
- As written, this file is not valid Python source code (a bare token like
kd0una.pywill raiseSyntaxErrorif the module is imported). If the intent is to alias/reuse another model implementation, replace this with an explicit Python shim (e.g., import/re-export logic) or make this a real symlink in git (mode 120000) rather than a.pymodule containing plain text.
"""Yeedi Floor 3 Station Capabilities."""
deebot_client/hardware/va8ygm.py:1
- If these one-line files are intended to be symlinks represented as file content, please confirm they are committed as actual symlinks (git mode 120000). Relying on symlinks can be fragile across platforms (notably Windows) and packaging formats; a small Python alias module (or a centralized mapping table used by the loader) is typically more portable and predictable.
deebot_client/hardware/rwp09o.py:1 - Adding many single-line alias modules increases file/module sprawl and makes it harder to audit which models map to which implementation. Consider consolidating these aliases into a single mapping structure (e.g., a dict of model_id -> base_model_id) consumed by the hardware loader, so adding a new similar model is a one-line mapping change rather than a new module file.
"""Yeedi Floor 3 Station Capabilities."""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1495 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 153 153
Lines 6010 6010
Branches 350 350
=======================================
Hits 5699 5699
Misses 249 249
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.