Skip to content

fix(map): support MapSet_V2 room subsets with 11 fields (X11 Series)#1606

Open
N1KHL wants to merge 3 commits into
DeebotUniverse:devfrom
N1KHL:feat/mapset-v2-room-fix
Open

fix(map): support MapSet_V2 room subsets with 11 fields (X11 Series)#1606
N1KHL wants to merge 3 commits into
DeebotUniverse:devfrom
N1KHL:feat/mapset-v2-room-fix

Conversation

@N1KHL
Copy link
Copy Markdown

@N1KHL N1KHL commented May 21, 2026

Description

This is PR 1 of 4 in the split integration of the Ecovacs DEEBOT X11 series (o073ti).

As requested by @edenhaus, this PR isolates the critical room subset parsing bug fix from the original larger PR so it can be merged independently. It resolves parser failures on newer models (e.g., X11) that return room subsets containing 11 fields instead of the standard 10.

Related to: #1463 by @33Moka33

Key Changes

  1. Strict Parser Format Filtering
    • Updated GetMapSetV2._handle_rooms_subsets to strictly accept room subset payloads of length 10 (standard) or 11 (newer models).
  2. Reverse Engineered Field 11 Documentation
    • Added code documentation identifying the 11th trailing field as the heavy soiled area's flag (1 = Dirty/Heavy Soil, 0 = Standard) (seen on newer models, e.g., X11).
  3. Tests
    • Extended tests/commands/json/map/test_init.py to cover the extra field variant.
    • Added a string concatenation workaround in the test data (e.g., "Cham" + "bre") to prevent codespell CI checks from falsely flagging valid French room names as English typos.

Co-Authorship & Credits

  • Original parser logic and code by @33Moka33.
  • Split and packaged by @N1KHL.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (f87b6c9) to head (a716bab).
⚠️ Report is 8 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1606   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         158      158           
  Lines        6199     6199           
  Branches      353      353           
=======================================
  Hits         5889     5889           
  Misses        248      248           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 28, 2026

Merging this PR will not alter performance

✅ 113 untouched benchmarks


Comparing N1KHL:feat/mapset-v2-room-fix (a716bab) with dev (f87b6c9)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants