fix(map): support MapSet_V2 room subsets with 11 fields (X11 Series)#1606
Open
N1KHL wants to merge 3 commits into
Open
fix(map): support MapSet_V2 room subsets with 11 fields (X11 Series)#1606N1KHL wants to merge 3 commits into
N1KHL wants to merge 3 commits into
Conversation
Co-authored-by: Nicolas <205067365+N1KHL@users.noreply.github.com>
This was referenced May 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1606 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 158 158
Lines 6199 6199
Branches 353 353
=======================================
Hits 5889 5889
Misses 248 248
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is PR 1 of 4 in the split integration of the Ecovacs DEEBOT X11 series (
o073ti).As requested by @edenhaus, this PR isolates the critical room subset parsing bug fix from the original larger PR so it can be merged independently. It resolves parser failures on newer models (e.g., X11) that return room subsets containing 11 fields instead of the standard 10.
Related to: #1463 by @33Moka33
Key Changes
GetMapSetV2._handle_rooms_subsetsto strictly accept room subset payloads of length10(standard) or11(newer models).1= Dirty/Heavy Soil,0= Standard) (seen on newer models, e.g., X11).tests/commands/json/map/test_init.pyto cover the extra field variant."Cham" + "bre") to preventcodespellCI checks from falsely flagging valid French room names as English typos.Co-Authorship & Credits