Skip to content

Add XML command "CleanArea"#817

Closed
flubshi wants to merge 3 commits into
DeebotUniverse:devfrom
flubshi:xml_clean_area
Closed

Add XML command "CleanArea"#817
flubshi wants to merge 3 commits into
DeebotUniverse:devfrom
flubshi:xml_clean_area

Conversation

@flubshi

@flubshi flubshi commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Our first XML clean command 🎉

Tested by cleaning my kitchen and bathroom multiple times.

@codecov

codecov Bot commented Feb 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (86fbe07) to head (34a3039).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/util/enum.py 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #817      +/-   ##
==========================================
- Coverage   91.58%   91.51%   -0.07%     
==========================================
  Files         114      116       +2     
  Lines        4360     4386      +26     
  Branches      292      294       +2     
==========================================
+ Hits         3993     4014      +21     
- Misses        299      304       +5     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Feb 10, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #817 will not alter performance

Comparing flubshi:xml_clean_area (34a3039) with dev (fc74a93)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to reduce

{
"type": mode.xml_value,
"act": CleanAction.START.xml_value,
"speed": "standard", # TODO: FanSpeedLevel.NORMAL.xml_value, after #560 is merged

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this mean that the bot will always start with the fan level at standard and not the one defined in the fan speed entity?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to pass it as parameter. But we have to wait for #560 for the new FanSpeedLevel Enum.

We can either merge it like it is and address this in another PR, or we wait for #560

Comment thread deebot_client/util/enum.py
@nanomad nanomad mentioned this pull request Apr 6, 2025
@flubshi

flubshi commented Apr 20, 2025

Copy link
Copy Markdown
Contributor Author

Closing in favor of #908

@flubshi flubshi closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants