Add XML command "CleanArea"#817
Closed
flubshi wants to merge 3 commits into
Closed
Conversation
25092b5 to
3181646
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## dev #817 +/- ##
==========================================
- Coverage 91.58% 91.51% -0.07%
==========================================
Files 114 116 +2
Lines 4360 4386 +26
Branches 292 294 +2
==========================================
+ Hits 3993 4014 +21
- Misses 299 304 +5
Partials 68 68 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 10, 2025
CodSpeed Performance ReportMerging #817 will not alter performanceComparing Summary
|
edenhaus
reviewed
Feb 10, 2025
| { | ||
| "type": mode.xml_value, | ||
| "act": CleanAction.START.xml_value, | ||
| "speed": "standard", # TODO: FanSpeedLevel.NORMAL.xml_value, after #560 is merged |
Member
There was a problem hiding this comment.
Would this mean that the bot will always start with the fan level at standard and not the one defined in the fan speed entity?
Contributor
Author
Closed
Contributor
Author
|
Closing in favor of #908 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our first XML clean command 🎉
Tested by cleaning my kitchen and bathroom multiple times.