Skip to content

Implement XML Command ResetLifeSpan#895

Merged
edenhaus merged 4 commits into
DeebotUniverse:devfrom
nanomad:feature/xml-reset-lifespan
Apr 28, 2025
Merged

Implement XML Command ResetLifeSpan#895
edenhaus merged 4 commits into
DeebotUniverse:devfrom
nanomad:feature/xml-reset-lifespan

Conversation

@nanomad

@nanomad nanomad commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

Also adds support for XML P2P commands

@codecov

codecov Bot commented Apr 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (1465b5c) to head (49b577c).
Report is 2 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #895      +/-   ##
==========================================
+ Coverage   92.78%   92.85%   +0.06%     
==========================================
  Files         125      125              
  Lines        4824     4868      +44     
  Branches      309      315       +6     
==========================================
+ Hits         4476     4520      +44     
  Misses        285      285              
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nanomad nanomad force-pushed the feature/xml-reset-lifespan branch from ce83770 to 323a38b Compare April 19, 2025 11:03
@codspeed-hq

codspeed-hq Bot commented Apr 19, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #895 will not alter performance

Comparing nanomad:feature/xml-reset-lifespan (49b577c) with dev (aed8470)

Summary

✅ 6 untouched benchmarks

@nanomad nanomad force-pushed the feature/xml-reset-lifespan branch 2 times, most recently from a4b9794 to 7ca3829 Compare April 19, 2025 11:45
@flubshi

flubshi commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

Awesome to see the progress. Thanks a lot @nanomad

@nanomad nanomad force-pushed the feature/xml-reset-lifespan branch 2 times, most recently from 433f18a to ae5fef9 Compare April 19, 2025 13:52
@nanomad nanomad marked this pull request as draft April 19, 2025 14:23
@nanomad nanomad force-pushed the feature/xml-reset-lifespan branch 2 times, most recently from 324889b to e9bd778 Compare April 22, 2025 11:24
@nanomad nanomad marked this pull request as ready for review April 22, 2025 11:24
@nanomad nanomad force-pushed the feature/xml-reset-lifespan branch 2 times, most recently from 24e906b to 98b7506 Compare April 26, 2025 10:03
@nanomad nanomad force-pushed the feature/xml-reset-lifespan branch from 98b7506 to c839412 Compare April 27, 2025 16:29
Comment thread deebot_client/commands/xml/common.py
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Apr 28, 2025

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus merged commit 14c7a7c into DeebotUniverse:dev Apr 28, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants