Skip to content

Add XML Map commands#909

Merged
edenhaus merged 5 commits into
DeebotUniverse:devfrom
nanomad:feature/xml-map-commands
Apr 27, 2025
Merged

Add XML Map commands#909
edenhaus merged 5 commits into
DeebotUniverse:devfrom
nanomad:feature/xml-map-commands

Conversation

@nanomad

@nanomad nanomad commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (8ed90f2) to head (f1f1c10).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #909      +/-   ##
==========================================
+ Coverage   92.57%   92.73%   +0.16%     
==========================================
  Files         122      123       +1     
  Lines        4671     4776     +105     
  Branches      292      304      +12     
==========================================
+ Hits         4324     4429     +105     
  Misses        285      285              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Apr 19, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #909 will not alter performance

Comparing nanomad:feature/xml-map-commands (f1f1c10) with dev (8ed90f2)

Summary

✅ 6 untouched benchmarks

@nanomad nanomad force-pushed the feature/xml-map-commands branch from a4fd6db to b9865e1 Compare April 20, 2025 00:30
@nanomad nanomad marked this pull request as ready for review April 20, 2025 19:56
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Apr 22, 2025
Comment thread deebot_client/commands/xml/map.py Outdated

def __init__(
self,
# pylint: disable=unused-argument

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add an unused param?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a piece of old code, but J've just realized we are missing the code that triggers a GetMapSet from GetMapSt

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edenhaus done, I've also made sure GetMapSt calls GetMapSet automatically as it does for the JSON variant

@nanomad nanomad marked this pull request as draft April 22, 2025 22:13
@nanomad nanomad force-pushed the feature/xml-map-commands branch from 8bb66ae to 3b8ad36 Compare April 24, 2025 10:41
Also remove deprecated unused argument from GetMapSet
@nanomad nanomad marked this pull request as ready for review April 24, 2025 10:50

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus enabled auto-merge (squash) April 27, 2025 15:45
@edenhaus edenhaus merged commit 475a1e5 into DeebotUniverse:dev Apr 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants