Add XML command SetCleanSpeed#911
Merged
edenhaus merged 6 commits intoApr 27, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #911 +/- ##
==========================================
+ Coverage 92.50% 92.57% +0.06%
==========================================
Files 122 122
Lines 4672 4671 -1
Branches 294 292 -2
==========================================
+ Hits 4322 4324 +2
+ Misses 288 285 -3
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #911 will not alter performanceComparing Summary
|
nanomad
force-pushed
the
feature/xml-fan-speed-commands
branch
from
e55b256 to
1fb19c2
Compare
edenhaus
requested changes
Apr 24, 2025
edenhaus
left a comment
edenhaus
left a comment
Member
There was a problem hiding this comment.
Please solve the merge conflicts
nanomad
force-pushed
the
feature/xml-fan-speed-commands
branch
from
1fb19c2 to
99673dd
Compare
Contributor
Author
@edenhaus conflicts solved, the CI pipeline crashed and needs restarting |
nanomad
force-pushed
the
feature/xml-fan-speed-commands
branch
from
99673dd to
d73dbe1
Compare
edenhaus
requested changes
Apr 25, 2025
nanomad
force-pushed
the
feature/xml-fan-speed-commands
branch
from
799b90a to
b39ebb1
Compare
Also add some support metods to check if a value is a valid XML Enum value
nanomad
force-pushed
the
feature/xml-fan-speed-commands
branch
from
b39ebb1 to
f28aade
Compare
Contributor
Author
|
@edenhaus Rebased |
edenhaus
changed the title
edenhaus
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #907