Skip to content

Fix water info events#932

Merged
edenhaus merged 1 commit into
devfrom
fix-water-events
Apr 28, 2025
Merged

Fix water info events#932
edenhaus merged 1 commit into
devfrom
fix-water-events

Conversation

@edenhaus

Copy link
Copy Markdown
Member

No description provided.

@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label Apr 28, 2025
Copilot AI review requested due to automatic review settings April 28, 2025 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the "water info events" by replacing type alias definitions with explicit class definitions that include descriptive docstrings.

  • Converted WaterAmountEvent, WaterSweepTypeEvent, and MopAttachedEvent from aliases to classes.
  • Added docstrings to each event class for improved clarity.

@codecov

codecov Bot commented Apr 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (8630f43) to head (ff2db56).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #932   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         125      125           
  Lines        4865     4865           
  Branches      315      315           
=======================================
  Hits         4517     4517           
  Misses        285      285           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Apr 28, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #932 will not alter performance

Comparing fix-water-events (ff2db56) with dev (8630f43)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus merged commit 0e9c0f1 into dev Apr 28, 2025
@edenhaus edenhaus deleted the fix-water-events branch April 28, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants