Skip to content

Fix XML Bots and add FirmwareEvent#935

Merged
edenhaus merged 9 commits into
DeebotUniverse:devfrom
nanomad:bugfix/xml-compat-changes
Apr 30, 2025
Merged

Fix XML Bots and add FirmwareEvent#935
edenhaus merged 9 commits into
DeebotUniverse:devfrom
nanomad:bugfix/xml-compat-changes

Conversation

@nanomad

@nanomad nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (4cc81d1) to head (cd96050).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #935      +/-   ##
==========================================
+ Coverage   92.84%   93.01%   +0.17%     
==========================================
  Files         125      125              
  Lines        4865     4885      +20     
  Branches      315      318       +3     
==========================================
+ Hits         4517     4544      +27     
+ Misses        285      282       -3     
+ Partials       63       59       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Apr 29, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #935 will not alter performance

Comparing nanomad:bugfix/xml-compat-changes (cd96050) with dev (4cc81d1)

Summary

✅ 6 untouched benchmarks

@nanomad

nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@edenhaus Those are the bugs I found while integration testing everything:

  • device.py was assuming any message could be decoded as JSON, erroring out on any XML bot message
  • message.py was not decoding string payloads properly. Strange that mypy didn't catch this as we were basically ignoring some valid payload types declared by MQTT

@nanomad

nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@edenhaus eventually I think we should switch the "bot firmware version" to be handled differently as for XML bots we have to send a specific command (not yet implemented) so I'd consider this portion of the patch more of a workaround

@edenhaus edenhaus changed the title Compatibility fixes for XML Bots Fixes for XML Bots Apr 29, 2025
@edenhaus edenhaus changed the title Fixes for XML Bots Fix XML Bots Apr 29, 2025
@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label Apr 29, 2025
@edenhaus

Copy link
Copy Markdown
Member

I refactored the code to use a FirmwareEvent, which can be used by the XML bot in the feature too

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus changed the title Fix XML Bots Fix XML Bots and add FirmwareEvent Apr 30, 2025
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Apr 30, 2025
@edenhaus edenhaus merged commit 66bc325 into DeebotUniverse:dev Apr 30, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants