Fix XML Bots and add FirmwareEvent#935
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #935 +/- ##
==========================================
+ Coverage 92.84% 93.01% +0.17%
==========================================
Files 125 125
Lines 4865 4885 +20
Branches 315 318 +3
==========================================
+ Hits 4517 4544 +27
+ Misses 285 282 -3
+ Partials 63 59 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #935 will not alter performanceComparing Summary
|
|
@edenhaus Those are the bugs I found while integration testing everything:
|
|
@edenhaus eventually I think we should switch the "bot firmware version" to be handled differently as for XML bots we have to send a specific command (not yet implemented) so I'd consider this portion of the patch more of a workaround |
|
I refactored the code to use a |
No description provided.