Skip to content

Change capabilities to support XML bots#937

Merged
edenhaus merged 5 commits into
devfrom
xml-capabilities
Apr 30, 2025
Merged

Change capabilities to support XML bots#937
edenhaus merged 5 commits into
devfrom
xml-capabilities

Conversation

@edenhaus

Copy link
Copy Markdown
Member

No description provided.

@edenhaus edenhaus added the pr: Breaking Change Pull request with braking changes label Apr 30, 2025
Copilot AI review requested due to automatic review settings April 30, 2025 09:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mapping and command capabilities to support XML bots by reordering parameters in method calls and constructors as well as marking some capabilities as optional.

  • Updated parameter ordering in minor command execution and corresponding JSON and XML command constructors
  • Adjusted type signatures in capabilities to reflect new order and optional capabilities

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
deebot_client/map.py Reordered parameters for minor command invocation to match changes.
deebot_client/commands/xml/map.py Changed the PullMP constructor signature to accept an extra parameter.
deebot_client/commands/json/map.py Reordered arguments to maintain consistency with capabilities change.
deebot_client/capabilities.py Updated type signatures for minor, multi_state, relocation, and volume.
Comments suppressed due to low confidence (1)

deebot_client/commands/xml/map.py:242

  • [nitpick] Consider renaming the unused parameter '_' to a more descriptive name or adding a comment to explain its purpose for clarity.
def __init__(self, piece_index: int, _: str | None = None) -> None:

Comment thread deebot_client/map.py
Comment thread deebot_client/capabilities.py
@codecov

codecov Bot commented Apr 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (4cc81d1) to head (272cd64).
Report is 2 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #937   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         125      125           
  Lines        4865     4865           
  Branches      315      315           
=======================================
  Hits         4517     4517           
  Misses        285      285           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Apr 30, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #937 will not alter performance

Comparing xml-capabilities (272cd64) with dev (4cc81d1)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus merged commit 9e7c8df into dev Apr 30, 2025
27 checks passed
@edenhaus edenhaus deleted the xml-capabilities branch April 30, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: Breaking Change Pull request with braking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants