Skip to content

Deebot T9 AIVI correct device#948

Closed
gpongelli wants to merge 1 commit into
DeebotUniverse:devfrom
gpongelli:deebot-t9-aivi
Closed

Deebot T9 AIVI correct device#948
gpongelli wants to merge 1 commit into
DeebotUniverse:devfrom
gpongelli:deebot-t9-aivi

Conversation

@gpongelli

Copy link
Copy Markdown
Contributor

As suggested in #922 (review) , this new PR fixes Deebot T9 AIVI device 659yh8 to correctly point to 8kwdb4 .

@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (49a6f5b) to head (e154de6).
Report is 12 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #948      +/-   ##
==========================================
+ Coverage   93.07%   93.27%   +0.19%     
==========================================
  Files         127      128       +1     
  Lines        4927     5070     +143     
  Branches      320      349      +29     
==========================================
+ Hits         4586     4729     +143     
+ Misses        282      279       -3     
- Partials       59       62       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 6, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #948 will not alter performance

Comparing gpongelli:deebot-t9-aivi (e154de6) with dev (023ae93)

Summary

✅ 6 untouched benchmarks

@edenhaus

edenhaus commented May 6, 2025

Copy link
Copy Markdown
Member

Did you test this change?

@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label May 6, 2025
@gpongelli

Copy link
Copy Markdown
Contributor Author

Did you test this change?

Actually I’ve added no tests, which kind of tests are expected?

I’ve done this change due to logs retrieved from my T9 AIVI #592 (comment)

@edenhaus

edenhaus commented May 7, 2025

Copy link
Copy Markdown
Member

Did you manually apply this change on your HA instance and checked if it is working correctly?

@gpongelli

Copy link
Copy Markdown
Contributor Author

Did you manually apply this change on your HA instance and checked if it is working correctly?

No I didn’t.
I based this PR’s need only on logs retrieved from vacuum.

I’ve no idea on how do test in my HA because it’s within docker container, can you point me to how to do that? Thanks.

@flubshi

flubshi commented May 11, 2025

Copy link
Copy Markdown
Contributor

@gpongelli it should work sth like that:

  • Login to Home Assistant via SSH:
    • ssh hassio@<ip>
  • Run shell in docker:
    • docker exec -it $(docker ps -f name=homeassistant -q) bash
  • Change to library directory:
    • cd /usr/local/lib/python3.13/site-packages/deebot_client/hardware/deebot
  • Remove existing link:
    • rm 659yh8.py
  • Link to 8kwdb4.py, as in this PR:
    • Link exmaple: ln -svfT <existing_model> <your_model>
    • ln -svfT 8kwdb4.py 659yh8.py
  • Restart home assistant

@gpongelli

Copy link
Copy Markdown
Contributor Author

thanks @flubshi I'll try.

what I would understand is why this kind of test is needed if the two files are the same ?

@edenhaus

Copy link
Copy Markdown
Member

what I would understand is why this kind of test is needed if the two files are the same ?

I assumed the two files are different. I now checked them and there are indeed the same. So no test are needed. Even this PR is not needed et all as the resulting file is the same so, so I will close it

@edenhaus edenhaus closed this May 11, 2025
@gpongelli

Copy link
Copy Markdown
Contributor Author

They refers to two different model:

  • T8 is x5d34r.py
  • T9 is 8kwdb4.py
  • 659yh8.py is my Deebot, that is a T9 AIVI which has some video streaming more than T9

Even if files are actually the same, is more correct to point 659yh8 to 8kwdb4c, to avoid confusion if in future video part will be developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants