Deebot T9 AIVI correct device#948
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #948 +/- ##
==========================================
+ Coverage 93.07% 93.27% +0.19%
==========================================
Files 127 128 +1
Lines 4927 5070 +143
Branches 320 349 +29
==========================================
+ Hits 4586 4729 +143
+ Misses 282 279 -3
- Partials 59 62 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #948 will not alter performanceComparing Summary
|
|
Did you test this change? |
Actually I’ve added no tests, which kind of tests are expected? I’ve done this change due to logs retrieved from my T9 AIVI #592 (comment) |
|
Did you manually apply this change on your HA instance and checked if it is working correctly? |
No I didn’t. I’ve no idea on how do test in my HA because it’s within docker container, can you point me to how to do that? Thanks. |
|
@gpongelli it should work sth like that:
|
|
thanks @flubshi I'll try. what I would understand is why this kind of test is needed if the two files are the same ? |
I assumed the two files are different. I now checked them and there are indeed the same. So no test are needed. Even this PR is not needed et all as the resulting file is the same so, so I will close it |
|
They refers to two different model:
Even if files are actually the same, is more correct to point 659yh8 to 8kwdb4c, to avoid confusion if in future video part will be developed. |
As suggested in #922 (review) , this new PR fixes Deebot T9 AIVI device 659yh8 to correctly point to 8kwdb4 .