Skip to content

XML ChargeState IDLE should not produce any events#956

Merged
edenhaus merged 2 commits into
DeebotUniverse:devfrom
nanomad:feature/ignore-xml-idle-charge-state
May 15, 2025
Merged

XML ChargeState IDLE should not produce any events#956
edenhaus merged 2 commits into
DeebotUniverse:devfrom
nanomad:feature/ignore-xml-idle-charge-state

Conversation

@nanomad

@nanomad nanomad commented May 8, 2025

Copy link
Copy Markdown
Contributor

Fixes #952

@nanomad nanomad changed the title ChargeState IDLE should not produce any events XML ChargeState IDLE should not produce any events May 8, 2025
@codecov

codecov Bot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (5b6d68b) to head (e6eccfa).
Report is 15 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #956   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         128      128           
  Lines        4995     4997    +2     
  Branches      331      332    +1     
=======================================
+ Hits         4653     4655    +2     
  Misses        282      282           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 8, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #956 will not alter performance

Comparing nanomad:feature/ignore-xml-idle-charge-state (e6eccfa) with dev (5b6d68b)

Summary

✅ 6 untouched benchmarks

Comment thread deebot_client/messages/xml/charge_state.py
@nanomad

nanomad commented May 13, 2025 via email

Copy link
Copy Markdown
Contributor Author

@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label May 15, 2025

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus merged commit 5d302c1 into DeebotUniverse:dev May 15, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ozmo 905: Continously bouncing between IDLE and CLEANING states during cleaning

2 participants