XML ChargeState IDLE should not produce any events#956
Merged
edenhaus merged 2 commits intoMay 15, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #956 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 128 128
Lines 4995 4997 +2
Branches 331 332 +1
=======================================
+ Hits 4653 4655 +2
Misses 282 282
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #956 will not alter performanceComparing Summary
|
edenhaus
reviewed
May 9, 2025
Contributor
Author
|
Sure, that's how I tested the scenario I described. The idle state comes
from the cleaning report messages not from the charger state
Il Mar 13 Mag 2025, 19:20 Robert Resch ***@***.***> ha
scritto:
… ***@***.**** commented on this pull request.
------------------------------
In deebot_client/messages/xml/charge_state.py
<#956 (comment)>
:
> match charge_type.lower():
case "slotcharging" | "slot_charging" | "wirecharging":
status = State.DOCKED
case "idle":
- status = State.IDLE
+ # Bot reports IDLE while not on the charger (e.g. while cleaning)
+ # We ignore this state since it will conflict with the actual cleaning state
+ pass
If i stop cleaning without pressing return to base:
IDLE
Can we still mark the bot as idle with the above changes?
—
Reply to this email directly, view it on GitHub
<#956 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIT3RXHF4XECSYPSVBJLHL26ISVPAVCNFSM6AAAAAB4XENLCGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZXGU4DANRXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
edenhaus
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #952