Skip to content

Remove dead code#958

Merged
edenhaus merged 2 commits into
devfrom
dead-code
May 9, 2025
Merged

Remove dead code#958
edenhaus merged 2 commits into
devfrom
dead-code

Conversation

@edenhaus

@edenhaus edenhaus commented May 9, 2025

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 9, 2025 14:17
@edenhaus edenhaus added the pr: refactor PR with code refactoring label May 9, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dead code from the deebot_client/models.py file to streamline the module.

  • Removed an unused import for Path.
  • Removed the unused _str_to_bool_or_cert function.

@codecov

codecov Bot commented May 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (2b18d80) to head (ea563d1).
Report is 2 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #958      +/-   ##
==========================================
+ Coverage   93.31%   93.60%   +0.29%     
==========================================
  Files         128      128              
  Lines        4993     4975      -18     
  Branches      330      324       -6     
==========================================
- Hits         4659     4657       -2     
+ Misses        274      258      -16     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 9, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #958 will not alter performance

Comparing dead-code (ea563d1) with dev (2b18d80)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus merged commit fd27901 into dev May 9, 2025
27 checks passed
@edenhaus edenhaus deleted the dead-code branch May 9, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: refactor PR with code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants