Fix xml custom coordinates cleaning command#982
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with XML custom coordinates cleaning commands by enhancing command handling and updating tests.
- Introduces support for custom area coordinates in cleaning commands.
- Adds new test cases for both XML and JSON commands and refactors the CleanArea class to support additional arguments.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/commands/xml/test_clean.py | Added a test case for CleanArea with custom coordinates using CleanMode.CUSTOM_AREA. |
| tests/commands/json/test_clean.py | Extended test cases to cover both legacy and new custom area coordinate commands. |
| deebot_client/commands/xml/clean.py | Refactored CleanArea to inherit from Clean; updated parameter naming and key mapping. |
Comments suppressed due to low confidence (2)
deebot_client/commands/xml/clean.py:52
- [nitpick] The parameter name 'area_or_coordinates' is ambiguous. Consider renaming it to a more descriptive name, such as 'value' or splitting it into two distinct parameters for area and coordinates if they represent different data.
area_or_coordinates: str,
deebot_client/commands/xml/clean.py:55
- The use of 'p' as a key for custom area coordinates is unclear. Consider using a more descriptive key name like 'coordinates' for better code clarity.
key = "area" if mode == CleanMode.SPOT_AREA else "p"
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #982 +/- ##
=======================================
Coverage 93.63% 93.64%
=======================================
Files 129 129
Lines 4999 5000 +1
Branches 325 326 +1
=======================================
+ Hits 4681 4682 +1
Misses 258 258
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #982 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#144850