Skip to content

Fix XML clean copy paste error#995

Merged
edenhaus merged 1 commit into
devfrom
xml-clean-copy-paste-error
May 29, 2025
Merged

Fix XML clean copy paste error#995
edenhaus merged 1 commit into
devfrom
xml-clean-copy-paste-error

Conversation

@edenhaus

Copy link
Copy Markdown
Member

Bug introduced in #982

Copilot AI review requested due to automatic review settings May 29, 2025 13:45
@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label May 29, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the XML clean process caused by a copy-paste error.

  • Updated key assignment in xml cleaning for the SPOT_AREA mode
  • Corrected the XML attribute mapping from "area" to "mid"
Comments suppressed due to low confidence (1)

deebot_client/commands/xml/clean.py:55

  • Verify that the updated key 'mid' correctly maps to the intended XML attribute for Spot Area cleaning as per the XML schema, ensuring that downstream handling expects 'mid'.
key = "mid" if mode == CleanMode.SPOT_AREA else "p"

@codecov

codecov Bot commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (bc3f06c) to head (6694905).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #995   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         129      129           
  Lines        5012     5012           
  Branches      327      327           
=======================================
  Hits         4694     4694           
  Misses        258      258           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 29, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #995 will not alter performance

Comparing xml-clean-copy-paste-error (6694905) with dev (bc3f06c)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus merged commit 7dab5cb into dev May 29, 2025
27 checks passed
@edenhaus edenhaus deleted the xml-clean-copy-paste-error branch May 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants