Fix XML clean copy paste error#995
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the XML clean process caused by a copy-paste error.
- Updated key assignment in xml cleaning for the SPOT_AREA mode
- Corrected the XML attribute mapping from "area" to "mid"
Comments suppressed due to low confidence (1)
deebot_client/commands/xml/clean.py:55
- Verify that the updated key 'mid' correctly maps to the intended XML attribute for Spot Area cleaning as per the XML schema, ensuring that downstream handling expects 'mid'.
key = "mid" if mode == CleanMode.SPOT_AREA else "p"
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #995 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 129 129
Lines 5012 5012
Branches 327 327
=======================================
Hits 4694 4694
Misses 258 258
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #995 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug introduced in #982