Skip to content

Add support for GOAT A3000 Lidar (cr0e4u)#998

Merged
edenhaus merged 1 commit into
DeebotUniverse:devfrom
f10:additional_goat_a3000_id
Jun 4, 2025
Merged

Add support for GOAT A3000 Lidar (cr0e4u)#998
edenhaus merged 1 commit into
DeebotUniverse:devfrom
f10:additional_goat_a3000_id

Conversation

@f10

@f10 f10 commented May 29, 2025

Copy link
Copy Markdown
Contributor

Change is untested as the id is different to my device.

@codecov

codecov Bot commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (7dab5cb) to head (adca981).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #998   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         129      129           
  Lines        5012     5012           
  Branches      327      327           
=======================================
  Hits         4694     4694           
  Misses        258      258           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 29, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #998 will not alter performance

Comparing f10:additional_goat_a3000_id (adca981) with dev (7dab5cb)

Summary

✅ 6 untouched benchmarks

@knobunc

knobunc commented May 30, 2025

Copy link
Copy Markdown

FWIW I tested it and got useful results back. I am new to the project so I can't swear they are 100% complete, but what fields are there had sane values.

@edenhaus edenhaus changed the title Another id for GOAT A3000 Lidar reported by @knobunc. Add support for GOAT A3000 Lidar (cr0e4u) Jun 4, 2025
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Jun 4, 2025
@edenhaus edenhaus merged commit 2cb321a into DeebotUniverse:dev Jun 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants