internal/tsutil: use IPNBusWatcher#229
Merged
DeedleFake merged 38 commits intomasterfrom May 23, 2025
Merged
Conversation
This makes way more sense. Now it doesn't require manual `struct{}{}`
usages and it can't be closed accidentally and break things.
…s of status information
This reverts commit 44c1826.
How in the world did I manage to do that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge overhaul of the polling mechanism. I tried doing this once before (#62) but ran into problems, but this time I was able to get it to work. The UI feels vastly better now that updates come in nearly instantly after a change is made.
The
Last Writerow for peers has been removed as there doesn't seem to be support for it withIPNBusWatcher. It's the one feature that I couldn't figure out a good way to replicate.This also makes the general login flow quite a bit cleaner and nicer.
Fixes #211. Fixes #212.
One known bug is that the window will freeze completely if Trayscale is started while the Tailscale daemon is completely not running. This is actually better than what used to happen, as before this change the window would just simply not open in the first place though Trayscale would run in the background.