|
| 1 | +package agents_engine.mcp |
| 2 | + |
| 3 | +import agents_engine.core.agent |
| 4 | +import java.net.URI |
| 5 | +import java.net.http.HttpClient |
| 6 | +import java.net.http.HttpRequest |
| 7 | +import java.net.http.HttpResponse |
| 8 | +import kotlin.test.AfterTest |
| 9 | +import kotlin.test.Test |
| 10 | +import kotlin.test.assertEquals |
| 11 | +import kotlin.test.assertTrue |
| 12 | +import kotlin.test.assertFalse |
| 13 | + |
| 14 | +// Tests for #1976 — McpServer prompt + resource handler branches (43 unkilled |
| 15 | +// mutants in handle / handlePromptGet / handleResourceRead / toMcpDescriptor). |
| 16 | +// Mirrors McpServerErrorPathsTest's raw-POST + HTTP-client pattern. |
| 17 | +// |
| 18 | +// Targets: |
| 19 | +// - handlePromptGet:190 (params Map cast) / 191 (missing name → -32602) |
| 20 | +// - handlePromptGet:193 (unknown prompt name → -32601) |
| 21 | +// - handlePromptGet:196 (args Map fallback when null) |
| 22 | +// - handlePromptGet:197 + 209 (render success/failure branches) |
| 23 | +// - handleResourceRead:228-231 (params/uri/registered-lookup) |
| 24 | +// - handleResourceRead:239 + 245 (read success/failure) |
| 25 | +// - toMcpDescriptor:216 (prompt arguments-list inclusion when non-empty) |
| 26 | +// - toMcpDescriptor:220 (per-arg description optional) |
| 27 | +// - toMcpDescriptor:252/253 (resource description+mimeType optional) |
| 28 | +// - handle:118-119 (body size guard boundary) |
| 29 | +// - handle:112/113 (Content-Length declaration handling) |
| 30 | +class McpServerPromptResourceHandlersTest { |
| 31 | + |
| 32 | + private val toStop = mutableListOf<() -> Unit>() |
| 33 | + @AfterTest fun cleanup() { toStop.forEach { runCatching { it() } } } |
| 34 | + |
| 35 | + private fun trivialAgent() = agent<String, String>("greeter") { |
| 36 | + skills { skill<String, String>("greet", "Greet") { implementedBy { "hi $it" } } } |
| 37 | + } |
| 38 | + |
| 39 | + private fun postRaw(url: String, body: String, contentLength: Long? = null): HttpResponse<String> { |
| 40 | + val builder = HttpRequest.newBuilder() |
| 41 | + .uri(URI.create(url)) |
| 42 | + .header("Content-Type", "application/json") |
| 43 | + .POST(HttpRequest.BodyPublishers.ofString(body)) |
| 44 | + if (contentLength != null) builder.header("Content-Length", contentLength.toString()) |
| 45 | + return HttpClient.newHttpClient().send(builder.build(), HttpResponse.BodyHandlers.ofString()) |
| 46 | + } |
| 47 | + |
| 48 | + private fun serverWithPrompts( |
| 49 | + configure: McpExposeBuilder.() -> Unit, |
| 50 | + ): McpServer { |
| 51 | + val server = McpServer.from(trivialAgent()) { |
| 52 | + expose("greet") // need at least one expose() OR prompt()/resource() |
| 53 | + port = 0 |
| 54 | + configure() |
| 55 | + }.start() |
| 56 | + toStop.add { server.stop() } |
| 57 | + return server |
| 58 | + } |
| 59 | + |
| 60 | + // ── handlePromptGet: missing/unknown name (lines 191, 193) ──────────────── |
| 61 | + |
| 62 | + @Test |
| 63 | + fun `prompts get with missing name returns -32602 error`() { |
| 64 | + // Kills NegateConditionals on line 191 (`name as? String ?: return ...`). |
| 65 | + val server = serverWithPrompts { |
| 66 | + prompt("hello", "Greets") { _ -> "Hello, world!" } |
| 67 | + } |
| 68 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"prompts/get","params":{}}""") |
| 69 | + assertEquals(200, r.statusCode()) |
| 70 | + assertTrue(r.body().contains("\"code\":-32602"), "missing name must use -32602 invalid-params: ${r.body()}") |
| 71 | + assertTrue(r.body().contains("Missing prompt name"), "error message should be descriptive: ${r.body()}") |
| 72 | + } |
| 73 | + |
| 74 | + @Test |
| 75 | + fun `prompts get with unknown name returns -32601 error`() { |
| 76 | + // Line 193: `registeredPrompts.firstOrNull { it.name == name } ?: return ...` |
| 77 | + val server = serverWithPrompts { |
| 78 | + prompt("hello", "Greets") { _ -> "Hi" } |
| 79 | + } |
| 80 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"prompts/get","params":{"name":"nonexistent"}}""") |
| 81 | + assertEquals(200, r.statusCode()) |
| 82 | + assertTrue(r.body().contains("\"code\":-32601"), "unknown prompt must use -32601 method-not-found: ${r.body()}") |
| 83 | + assertTrue(r.body().contains("nonexistent"), "error must name the unknown prompt: ${r.body()}") |
| 84 | + } |
| 85 | + |
| 86 | + // ── handlePromptGet: happy path (line 197 + 199-207) ────────────────────── |
| 87 | + |
| 88 | + @Test |
| 89 | + fun `prompts get happy path returns rendered prompt with description`() { |
| 90 | + // Line 192 + 194 + 197: the result envelope must carry the right shape. |
| 91 | + // `replaced return value with ""` mutants on 192/194/197 would yield |
| 92 | + // empty/null bodies; this test pins the actual content. |
| 93 | + val server = serverWithPrompts { |
| 94 | + prompt("greet", "Say hi to a person", arguments = listOf( |
| 95 | + McpPromptArgument("name", "Who to greet", required = true) |
| 96 | + )) { args -> "Hello, ${args["name"]}!" } |
| 97 | + } |
| 98 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":42,"method":"prompts/get","params":{"name":"greet","arguments":{"name":"Alice"}}}""") |
| 99 | + assertEquals(200, r.statusCode()) |
| 100 | + val body = r.body() |
| 101 | + assertTrue(body.contains("\"description\":\"Say hi to a person\""), |
| 102 | + "result must include the prompt description: $body") |
| 103 | + assertTrue(body.contains("Hello, Alice!"), |
| 104 | + "result must include the rendered prompt text: $body") |
| 105 | + assertTrue(body.contains("\"role\":\"user\""), "messages must be user-role: $body") |
| 106 | + assertTrue(body.contains("\"id\":42"), "id must round-trip: $body") |
| 107 | + } |
| 108 | + |
| 109 | + @Test |
| 110 | + fun `prompts get with null arguments falls back to empty map (line 196)`() { |
| 111 | + // Line 196: `(params["arguments"] as? Map<String, Any?>) ?: emptyMap()` |
| 112 | + // The render closure must receive an empty map, not crash on null. |
| 113 | + var seen: Map<String, Any?>? = null |
| 114 | + val server = serverWithPrompts { |
| 115 | + prompt("no-args", "no args") { args -> seen = args; "static text" } |
| 116 | + } |
| 117 | + // params has name but NO arguments field. |
| 118 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"prompts/get","params":{"name":"no-args"}}""") |
| 119 | + assertEquals(200, r.statusCode()) |
| 120 | + assertTrue(r.body().contains("static text")) |
| 121 | + assertEquals(emptyMap<String, Any?>(), seen, "render must receive empty map when arguments missing") |
| 122 | + } |
| 123 | + |
| 124 | + // ── handlePromptGet: render throws (line 208-210) ───────────────────────── |
| 125 | + |
| 126 | + @Test |
| 127 | + fun `prompts get render throwing returns -32603 internal error with cause message`() { |
| 128 | + // Line 208-210: the catch wraps any exception in -32603 with "Prompt 'X' rendering failed: <msg>". |
| 129 | + val server = serverWithPrompts { |
| 130 | + prompt("explosive", "Boom") { _ -> throw IllegalStateException("kapow") } |
| 131 | + } |
| 132 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"prompts/get","params":{"name":"explosive"}}""") |
| 133 | + assertEquals(200, r.statusCode()) |
| 134 | + val body = r.body() |
| 135 | + assertTrue(body.contains("\"code\":-32603"), "render exception → internal error: $body") |
| 136 | + assertTrue(body.contains("kapow"), "original exception message must propagate: $body") |
| 137 | + assertTrue(body.contains("rendering failed"), "wrapper text must appear: $body") |
| 138 | + } |
| 139 | + |
| 140 | + // ── handleResourceRead: missing/unknown uri (lines 229, 231) ────────────── |
| 141 | + |
| 142 | + @Test |
| 143 | + fun `resources read with missing uri returns -32602 error`() { |
| 144 | + val server = serverWithPrompts { |
| 145 | + resource("file:///x", name = "x") { "content" } |
| 146 | + } |
| 147 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"resources/read","params":{}}""") |
| 148 | + assertEquals(200, r.statusCode()) |
| 149 | + assertTrue(r.body().contains("\"code\":-32602")) |
| 150 | + assertTrue(r.body().contains("Missing resource uri")) |
| 151 | + } |
| 152 | + |
| 153 | + @Test |
| 154 | + fun `resources read with unknown uri returns -32601 error`() { |
| 155 | + val server = serverWithPrompts { |
| 156 | + resource("file:///known", name = "k") { "content" } |
| 157 | + } |
| 158 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"resources/read","params":{"uri":"file:///nope"}}""") |
| 159 | + assertEquals(200, r.statusCode()) |
| 160 | + assertTrue(r.body().contains("\"code\":-32601")) |
| 161 | + assertTrue(r.body().contains("file:///nope"), "error must name the unknown uri: ${r.body()}") |
| 162 | + } |
| 163 | + |
| 164 | + // ── handleResourceRead: happy path (lines 233-243) ──────────────────────── |
| 165 | + |
| 166 | + @Test |
| 167 | + fun `resources read happy path returns the resource content with mimeType`() { |
| 168 | + val server = serverWithPrompts { |
| 169 | + resource("doc://x", name = "X-doc", mimeType = "text/markdown") { |
| 170 | + "# Hello\nThis is content." |
| 171 | + } |
| 172 | + } |
| 173 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":7,"method":"resources/read","params":{"uri":"doc://x"}}""") |
| 174 | + assertEquals(200, r.statusCode()) |
| 175 | + val body = r.body() |
| 176 | + assertTrue(body.contains("doc://x")) |
| 177 | + assertTrue(body.contains("text/markdown")) |
| 178 | + assertTrue(body.contains("Hello")) |
| 179 | + assertTrue(body.contains("\"id\":7"), "id round-trip: $body") |
| 180 | + } |
| 181 | + |
| 182 | + @Test |
| 183 | + fun `resources read happy path without mimeType omits the field`() { |
| 184 | + // Line 239: `resource.mimeType?.let { put("mimeType", it) }` — the let block |
| 185 | + // only runs when mimeType is non-null. Mutant negates this and would emit |
| 186 | + // the field with a null/missing value. |
| 187 | + val server = serverWithPrompts { |
| 188 | + resource("plain://x", name = "Plain") { "just text" } |
| 189 | + } |
| 190 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"resources/read","params":{"uri":"plain://x"}}""") |
| 191 | + assertEquals(200, r.statusCode()) |
| 192 | + assertFalse(r.body().contains("mimeType"), |
| 193 | + "mimeType field should be absent when not declared: ${r.body()}") |
| 194 | + } |
| 195 | + |
| 196 | + // ── handleResourceRead: read throws (line 244-246) ──────────────────────── |
| 197 | + |
| 198 | + @Test |
| 199 | + fun `resources read throwing returns -32603 with cause message`() { |
| 200 | + val server = serverWithPrompts { |
| 201 | + resource("file:///broken", name = "B") { throw RuntimeException("io fail") } |
| 202 | + } |
| 203 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"resources/read","params":{"uri":"file:///broken"}}""") |
| 204 | + assertEquals(200, r.statusCode()) |
| 205 | + val body = r.body() |
| 206 | + assertTrue(body.contains("\"code\":-32603")) |
| 207 | + assertTrue(body.contains("io fail")) |
| 208 | + assertTrue(body.contains("read failed")) |
| 209 | + } |
| 210 | + |
| 211 | + // ── prompts/list + RegisteredPrompt.toMcpDescriptor (lines 216, 220) ────── |
| 212 | + |
| 213 | + @Test |
| 214 | + fun `prompts list emits arguments only when prompt has arguments`() { |
| 215 | + // Line 216 in toMcpDescriptor: `if (arguments.isNotEmpty()) put(...)`. |
| 216 | + // Negated mutant would emit an empty arguments list or skip non-empty ones. |
| 217 | + val server = serverWithPrompts { |
| 218 | + prompt("with-args", "Has args", arguments = listOf( |
| 219 | + McpPromptArgument("a", "first", required = true) |
| 220 | + )) { _ -> "x" } |
| 221 | + prompt("no-args", "No args") { _ -> "y" } |
| 222 | + } |
| 223 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"prompts/list"}""") |
| 224 | + assertEquals(200, r.statusCode()) |
| 225 | + val body = r.body() |
| 226 | + assertTrue(body.contains("with-args"), "list must include with-args prompt: $body") |
| 227 | + assertTrue(body.contains("no-args"), "list must include no-args prompt: $body") |
| 228 | + // with-args section should have an "arguments" key; no-args section should NOT. |
| 229 | + // We can't easily slice the JSON, but we assert the per-arg name is present. |
| 230 | + assertTrue(body.contains("\"name\":\"a\""), "arguments list must surface arg name: $body") |
| 231 | + assertTrue(body.contains("\"description\":\"first\""), |
| 232 | + "arg description must surface (kills line 220 optional-description mutant): $body") |
| 233 | + assertTrue(body.contains("\"required\":true")) |
| 234 | + } |
| 235 | + |
| 236 | + // ── resources/list + RegisteredResource.toMcpDescriptor (lines 252, 253) ── |
| 237 | + |
| 238 | + @Test |
| 239 | + fun `resources list emits description and mimeType only when non-null`() { |
| 240 | + // Lines 252 + 253: `description?.let { put(...) }` and same for mimeType. |
| 241 | + val server = serverWithPrompts { |
| 242 | + resource("doc://full", name = "Full", |
| 243 | + description = "with details", mimeType = "text/plain") { "content" } |
| 244 | + resource("doc://bare", name = "Bare") { "content" } |
| 245 | + } |
| 246 | + val r = postRaw(server.url, """{"jsonrpc":"2.0","id":1,"method":"resources/list"}""") |
| 247 | + assertEquals(200, r.statusCode()) |
| 248 | + val body = r.body() |
| 249 | + assertTrue(body.contains("doc://full")) |
| 250 | + assertTrue(body.contains("doc://bare")) |
| 251 | + assertTrue(body.contains("\"description\":\"with details\""), |
| 252 | + "full resource description must surface: $body") |
| 253 | + assertTrue(body.contains("\"mimeType\":\"text/plain\""), |
| 254 | + "full resource mimeType must surface: $body") |
| 255 | + } |
| 256 | + |
| 257 | + // NOTE on handle:112-115 (Content-Length declared-length check): |
| 258 | + // Java's HttpClient restricts the "Content-Length" header from being set |
| 259 | + // manually (throws IllegalArgumentException: restricted header name). |
| 260 | + // To exercise the declared-length branch we'd need a different HTTP client |
| 261 | + // (or a raw Socket-level test). `McpServerBodySizeLimitTest` covers the |
| 262 | + // unbound-body length-capped read path which is the more interesting one |
| 263 | + // anyway. Leaving the declared-length branch unkilled for now — it's the |
| 264 | + // same logic shape as the unbound path, just an optimization for clients |
| 265 | + // that announce up front. |
| 266 | +} |
0 commit comments