Improve duplicate camera detection and reporting

Change seen from a set to a mapping of identity key -> camera_id to record which camera produced each key. Add get_camera_id and fallback to camera_id if camera_identity_key raises, logging the exception. Emit a more informative initialization_failed message that includes the camera_id and the conflicting camera, improving diagnostics and robustness when computing identity keys.

Author: C-Achard

dlclivegui/services/multi_camera_controller.py

@@ -185,13 +185,30 @@ def start(self, camera_settings: list[CameraSettings]) -> None:
             return
 
         # Check for dupes
-        seen = set()
+        seen = {}
         for s in active_settings:
-            key = camera_identity_key(s)
+            camera_id = get_camera_id(s)
+            try:
+                key = camera_identity_key(s)
+            except Exception:
+                LOGGER.exception(
+                    "Failed to compute camera identity key for %s; falling back to camera_id",
+                    camera_id,
+                )
+                key = camera_id
+
             if key in seen:
-                self.initialization_failed.emit([(key, "Duplicate camera configuration")])
+                self.initialization_failed.emit(
+                    [
+                        (
+                            camera_id,
+                            f"Duplicate camera configuration. Conflicts with {seen[key]}",
+                        )
+                    ]
+                )
                 return
-            seen.add(key)
+
+            seen[key] = camera_id
 
         self._running = True
         self._frames.clear()