Remove tiled frame generation and accessors

Delete the internal _create_tiled_frame implementation and the public frame accessors (get_frame, get_all_frames, get_tiled_frame) from MultiCameraController. This removes the tiled canvas construction logic and convenience getters for retrieving camera frames; update any callers to use the controller's new/alternate APIs or access frames via the updated code paths.

Author: C-Achard

dlclivegui/services/multi_camera_controller.py

@@ -677,98 +677,6 @@ def to_display_pixmap(frame: np.ndarray) -> QPixmap:
         q_img = QImage(frame.data, w, h, bytes_per_line, QImage.Format.Format_RGB888).copy()
         return QPixmap.fromImage(q_img)
 
-    def _create_tiled_frame(self) -> np.ndarray:
-        """Create a tiled frame from all camera frames.
-
-        The tiled frame is scaled to fit within a maximum canvas size
-        while maintaining aspect ratio of individual camera frames.
-        """
-        if not self._frames:
-            return np.zeros((480, 640, 3), dtype=np.uint8)
-
-        frames_list = [self._frames[idx] for idx in sorted(self._frames.keys())]
-        num_frames = len(frames_list)
-
-        if num_frames == 0:
-            return np.zeros((480, 640, 3), dtype=np.uint8)
-
-        # Determine grid layout
-        if num_frames == 1:
-            rows, cols = 1, 1
-        elif num_frames == 2:
-            rows, cols = 1, 2
-        elif num_frames <= 4:
-            rows, cols = 2, 2
-        else:
-            rows, cols = 2, 2  # Limit to 4
-
-        # Maximum canvas size to fit on screen (leaving room for UI elements)
-        max_canvas_width = 1200
-        max_canvas_height = 800
-
-        # Calculate tile size based on frame aspect ratio and available space
-        first_frame = frames_list[0]
-        frame_h, frame_w = first_frame.shape[:2]
-        frame_aspect = frame_w / frame_h if frame_h > 0 else 1.0
-
-        # Calculate tile dimensions that fit within the canvas
-        tile_w = max_canvas_width // cols
-        tile_h = max_canvas_height // rows
-
-        # Maintain aspect ratio of original frames
-        tile_aspect = tile_w / tile_h if tile_h > 0 else 1.0
-
-        if frame_aspect > tile_aspect:
-            # Frame is wider than tile slot - constrain by width
-            tile_h = int(tile_w / frame_aspect)
-        else:
-            # Frame is taller than tile slot - constrain by height
-            tile_w = int(tile_h * frame_aspect)
-
-        # Ensure minimum size
-        tile_w = max(160, tile_w)
-        tile_h = max(120, tile_h)
-
-        # Create canvas
-        canvas = np.zeros((rows * tile_h, cols * tile_w, 3), dtype=np.uint8)
-
-        # Get sorted camera IDs for consistent ordering
-        cam_ids = sorted(self._frames.keys())
-        frames_list = [self._frames[cam_id] for cam_id in cam_ids]
-
-        # Place each frame in the grid
-        for idx, frame in enumerate(frames_list[: rows * cols]):
-            row = idx // cols
-            col = idx % cols
-
-            # Ensure frame is 3-channel
-            frame = MultiCameraController.ensure_color_bgr(frame)
-
-            # Resize to tile size
-            resized = MultiCameraController.apply_resize(frame, tile_w, tile_h, allow_upscale=True)
-
-            # Add camera ID label
-            if idx < len(cam_ids):
-                label = cam_ids[idx]
-                cv2.putText(
-                    resized,
-                    label,
-                    (10, 30),
-                    cv2.FONT_HERSHEY_SIMPLEX,
-                    0.7,
-                    (0, 255, 0),
-                    2,
-                )
-
-            # Place in canvas
-            y_start = row * tile_h
-            y_end = y_start + tile_h
-            x_start = col * tile_w
-            x_end = x_start + tile_w
-            canvas[y_start:y_end, x_start:x_end] = resized
-
-        return canvas
-
     def _on_camera_started(self, camera_id: str) -> None:
         """Handle camera start event."""
         self._started_cameras.add(camera_id)
@@ -831,20 +739,3 @@ def _on_camera_error(self, camera_id: str, message: str) -> None:
         if camera_id not in self._started_cameras:
             self._failed_cameras[camera_id] = message
         self.camera_error.emit(camera_id, message)
-
-    def get_frame(self, camera_id: str) -> np.ndarray | None:
-        """Get the latest frame from a specific camera."""
-        with self._frame_lock:
-            return self._frames.get(camera_id)
-
-    def get_all_frames(self) -> dict[str, np.ndarray]:
-        """Get the latest frames from all cameras."""
-        with self._frame_lock:
-            return dict(self._frames)
-
-    def get_tiled_frame(self) -> np.ndarray | None:
-        """Get a tiled view of all camera frames."""
-        with self._frame_lock:
-            if self._frames:
-                return self._create_tiled_frame()
-        return None