Skip to content

Commit 3a0fe11

Browse files
committed
Track encoding errors with writer_timing
Fix the video encoding error path in VideoRecorder by replacing _process_timing with _writer_timing so encoding failures are recorded and logged against the correct timing object. This ensures error timing and maybe_log are invoked on the writer timing tracker rather than the wrong object.
1 parent 4629c08 commit 3a0fe11

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

dlclivegui/services/video_recorder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,8 @@ def _writer_loop(self) -> None:
387387
self._encode_error = exc
388388
logger.exception("Video encoding failed while writing frame", exc_info=exc)
389389
self._stop_event.set()
390-
self._process_timing.note_error()
391-
self._process_timing.maybe_log()
390+
self._writer_timing.note_error()
391+
self._writer_timing.maybe_log()
392392
break
393393
else:
394394
elapsed = time.perf_counter() - start

0 commit comments

Comments
 (0)