Cleanup abandoned recorder and set pending reset

Ensure proper cleanup and restartability when writer threads time out: VideoRecorder.stop now clears abandoned state and associated resources if the writer thread has already exited, allowing the recorder to be fully stopped and restarted. DLCLiveProcessor: moved settings/processor assignment under the lifecycle lock, and mark _pending_reset when shutdown cannot stop the worker thread so the instance can be reaped later. Minor comment tweak for STOP_WORKER_TIMEOUT semantics. Tests updated to assert abandoned is cleared and that recorder can be restarted after the writer exits.

Author: C-Achard

dlclivegui/services/dlc_processor.py

@@ -21,7 +21,7 @@
 from dlclivegui.temp import Engine  # type: ignore # TODO use main package enum when released
 
 logger = logging.getLogger(__name__)
-STOP_WORKER_TIMEOUT = 10.0  # seconds to wait for worker thread to stop before marking as faulted
+STOP_WORKER_TIMEOUT = 10.0  # seconds to wait for worker thread to stop before STOPPING state and reaping
 
 try:  # pragma: no cover - optional dependency
     from dlclive import (
@@ -184,8 +184,8 @@ def configure(self, settings: DLCProcessorSettings, processor: Any | None = None
         with self._lifecycle_lock:
             if self._state != WorkerState.STOPPED:
                 raise RuntimeError("Cannot configure DLCLiveProcessor while it is running. Please stop it first.")
-        self._settings = settings
-        self._processor = processor
+            self._settings = settings
+            self._processor = processor
 
     def reset(self) -> None:
         """Stop the worker thread and drop the current DLCLive instance."""
@@ -215,6 +215,8 @@ def reset(self) -> None:
     def shutdown(self) -> None:
         stopped = self._stop_worker()
         if not stopped:
+            with self._lifecycle_lock:
+                self._pending_reset = True
             logger.warning(
                 "Shutdown requested but worker thread is still alive; DLCLive instance may not be fully released."
             )

dlclivegui/services/video_recorder.py

@@ -212,7 +212,16 @@ def write(self, frame: np.ndarray, timestamp: float | None = None) -> bool:
     def stop(self) -> None:
         with self._lifecycle_lock:
             if self._writer is None and not self.is_running:
-                return
+                # If the recorder was previously marked as abandoned because the
+                # writer thread did not stop in time, but the thread has since
+                # exited, perform cleanup so the recorder can become fully stopped
+                # and restartable.
+                t = self._writer_thread
+                if self._abandoned and (t is None or not t.is_alive()):
+                    self._writer_thread = None
+                    self._queue = None
+                    self._stop_event.clear()
+                    self._abandoned = False
 
             self._stop_event.set()
 

tests/services/test_video_recorder.py

@@ -367,3 +367,8 @@ def test_stop_timeout_marks_abandoned_and_prevents_restart(
 
     # Call stop again to clear resources / reset flags (now it can join cleanly)
     rec.stop()
+    # After the writer thread has exited, a second stop() should fully reset state
+    # so that the recorder is no longer marked as abandoned and can be restarted.
+    assert rec._abandoned is False
+    rec.start()
+    rec.stop()