Clarify comment about QMessageBox crash wording

C-Achard · C-Achard · commit 791b0211aee9 · 2026-02-05T10:49:26.000+01:00
Reword the comment describing potential issues when a QTimer-triggered validation opens a modal QMessageBox while the parent window is closing. Replace the Windows-specific phrasing with a more general note about errors with unpredictable timing (heap corruption / access violations). No functional change; tests/CI mitigation guidance remains.
diff --git a/dlclivegui/gui/main_window.py b/dlclivegui/gui/main_window.py
@@ -185,7 +185,7 @@ def __init__(self, config: ApplicationSettings | None = None):
         # NOTE IMPORTANT (tests/CI): This is scheduled via a QTimer and may fire during pytest-qt teardown.
         QTimer.singleShot(100, self._validate_configured_cameras)
         # If validation triggers a modal QMessageBox (warning/error) while the parent window is closing,
-        # it can cause Windows native crashes (heap corruption / access violations).
+        # it can cause errors with unpredictable timing (heap corruption / access violations).
         #
         # Mitigations for tests/CI:
         #   - Disable this timer by monkeypatching _validate_configured_cameras in GUI tests

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ def __init__(self, config: ApplicationSettings \| None = None):`
`185`	`185`	`# NOTE IMPORTANT (tests/CI): This is scheduled via a QTimer and may fire during pytest-qt teardown.`
`186`	`186`	`QTimer.singleShot(100, self._validate_configured_cameras)`
`187`	`187`	`# If validation triggers a modal QMessageBox (warning/error) while the parent window is closing,`
`188`		`- # it can cause Windows native crashes (heap corruption / access violations).`
	`188`	`+ # it can cause errors with unpredictable timing (heap corruption / access violations).`
`189`	`189`	`#`
`190`	`190`	`# Mitigations for tests/CI:`
`191`	`191`	`# - Disable this timer by monkeypatching _validate_configured_cameras in GUI tests`