Skip to content

Commit ed1a9f5

Browse files
committed
Support fp: targets and downgrade CTI error log
Treat target IDs starting with "fp:" as valid and return settings early so open() can match devices by fingerprint via existing _select_device/_match_device logic. Also change CTI file load failures from logger.exception to logger.warning to reduce noisy stack traces while still recording failed files for diagnostics.
1 parent 0af5615 commit ed1a9f5

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

dlclivegui/cameras/backends/gentl_backend.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,9 @@ def rebind_settings(cls, settings):
337337
cls._persist_serial_identity(settings, target_id_str)
338338
return settings
339339

340+
if target_id_str.startswith("fp:"):
341+
return settings # open() will match by fingerprint via _select_device → _match_device
342+
340343
# Non-serial fallback retained for older configs / fingerprint IDs.
341344
harvester = None
342345
try:

dlclivegui/cameras/backends/utils/gentl_discovery.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def __init__(self, cti_files: list[str]):
5151
self.harvester.add_file(cti)
5252
self.loaded_files.append(cti)
5353
except Exception as e:
54-
logger.exception(f"Failed to load CTI file: {cti}. Skipping.")
54+
logger.warning(f"Failed to load CTI file: {cti}. Skipping.")
5555
self.failed_files[cti] = str(e)
5656

5757
if not self.loaded_files:

0 commit comments

Comments
 (0)