fix: handle non-numeric values in _is_nan_value to prevent save failure (closes #219)#224
Closed
botbikamordehai2-sketch wants to merge 1 commit into
Closed
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When saving labels in the napari plugin, the
_is_nan_valuefunction inmisc.pyattempts to callnp.isnan()on values that may be non-numeric (e.g., strings, tuples in MultiIndex columns). This raises an unhandled exception that prevents the save dialog from completing, leaving no feedback to the user. The traceback shows the error originates from the write path.Fix
Modify
_is_nan_valueto check if the input is numeric before callingnp.isnan(). Non-numeric values are returned asFalse(they are not NaN). This ensures the helper function_array_has_nanworks correctly on mixed-type arrays such as those with MultiIndex column labels.Closes #219