Commit 190fa0b
refactor(cache): remove dead code for undefined marker check (Issue #7)
Removed unreachable code in CacheService.get() method.
Analysis:
- CacheService.set() prevents undefined from being cached (Issue #10 fix)
- Therefore, get() will never encounter '__UNDEFINED__' marker
- Removed 4 lines of dead code checking for this marker
Code Removed:
```typescript
// Check for undefined marker
if (row.value === '__UNDEFINED__') {
return undefined;
}
```
Replaced With:
- Clarifying comment explaining undefined values are never cached
- Direct JSON.parse() without unnecessary check
Impact:
- Cleaner, more maintainable code
- Eliminates confusion about undefined handling
- Removes unreachable code path
- All 1454 tests still passing
CHANGELOG.md updated with refactoring details.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent a442194 commit 190fa0b
2 files changed
Lines changed: 12 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
67 | 77 | | |
68 | 78 | | |
69 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
| 150 | + | |
| 151 | + | |
155 | 152 | | |
156 | 153 | | |
157 | 154 | | |
| |||
0 commit comments