refactor(test): tighten test suite for endpoint resolution PR

- Rewrite resolve-endpoint tests from 43 to 25 using table-driven it.each()
  (covers all 5 priority branches + edge cases: subdomain spoof, URL parsing)
- Consolidate free-key-auth-init tests from 5 to 3 (drop redundant InitCommand)
- Reduce voice wiring test from 4 to 1 (pin passthrough, not permutations)
- Remove 55 expect(true).toBe(true) anti-pattern across integration/e2e tests
- Add expect.assertions(N) guards to 10 must-fail tests (API key required, etc.)
- Add InitCommand :fx key test to init-command.test.ts (closes coverage gap)

Net: 3486 → 3464 tests, zero branch coverage lost, -466 lines of test code.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sjsyrek

tests/e2e/cli-stdin-stdout.e2e.test.ts

@@ -125,7 +125,6 @@ describe('CLI Stdin/Stdout E2E', () => {
         expect(content).toMatch(/\d+\.\d+\.\d+/);
       } catch (error) {
         // File may not exist if command failed, but shouldn't crash
-        expect(true).toBe(true);
       }
     });
 
@@ -144,7 +143,6 @@ describe('CLI Stdin/Stdout E2E', () => {
         expect(result).toContain('Usage:');
       } catch (error) {
         // May fail if grep doesn't find pattern, but shouldn't crash
-        expect(true).toBe(true);
       }
     });
 

tests/e2e/cli-workflow.e2e.test.ts

@@ -350,16 +350,17 @@ describe('CLI Workflow E2E', () => {
         // Ignore if already cleared
       }
 
+      expect.assertions(1);
       try {
         runCLI('deepl glossary languages');
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout ?? error.message;
         expect(output).toMatch(/API key|auth/i);
       }
     });
 
     it('should not require any arguments', () => {
+      expect.assertions(2);
       try {
         // Will fail without API key but should not require arguments
         runCLI('deepl glossary languages');
@@ -379,9 +380,9 @@ describe('CLI Workflow E2E', () => {
         // Ignore if already cleared
       }
 
+      expect.assertions(1);
       try {
         runCLI('deepl glossary languages');
-        expect(true).toBe(true);
       } catch (error: any) {
         // Non-zero exit code
         expect(error.status).toBeGreaterThan(0);
@@ -760,9 +761,9 @@ describe('CLI Workflow E2E', () => {
     });
 
     it('should require API key for style-rules list', () => {
+      expect.assertions(1);
       try {
         runCLI('deepl style-rules list');
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).toMatch(/API key|auth/i);
@@ -772,7 +773,6 @@ describe('CLI Workflow E2E', () => {
     it('should accept --detailed and pagination flags', () => {
       try {
         runCLI('deepl style-rules list --detailed --page 1 --page-size 10');
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).not.toMatch(/unknown.*option/i);
@@ -784,7 +784,6 @@ describe('CLI Workflow E2E', () => {
     it('should accept extended language codes like Swahili', () => {
       try {
         runCLI('deepl translate "Hello" --to sw');
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).not.toMatch(/Invalid target language/i);
@@ -794,7 +793,6 @@ describe('CLI Workflow E2E', () => {
     it('should accept ES-419 Latin American Spanish', () => {
       try {
         runCLI('deepl translate "Hello" --to es-419');
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).not.toMatch(/Invalid target language/i);
@@ -804,7 +802,6 @@ describe('CLI Workflow E2E', () => {
     it('should accept Chinese simplified/traditional variants', () => {
       try {
         runCLI('deepl translate "Hello" --to zh-hant');
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).not.toMatch(/Invalid target language/i);
@@ -818,7 +815,6 @@ describe('CLI Workflow E2E', () => {
         runCLI(
           'deepl translate "<p>Hello</p>" --to es --tag-handling html --tag-handling-version v2'
         );
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).not.toMatch(/unknown.*option/i);

tests/integration/cli-auth.integration.test.ts

@@ -27,7 +27,6 @@ describe('Auth CLI Integration', () => {
     it('should store valid API key in config file', () => {
       // This will fail validation but should test the storage logic
       // For now, skip actual execution as it requires API validation
-      expect(true).toBe(true);
     });
 
     it('should reject empty API key', () => {

tests/integration/cli-config.integration.test.ts

@@ -170,7 +170,6 @@ describe('Config CLI Integration', () => {
       // Config file should be removed or reset
       // (implementation may vary - either delete or reset to defaults)
       // This test validates the reset command executes successfully
-      expect(true).toBe(true);
     });
 
     it('should abort without --yes in non-TTY mode', () => {

tests/integration/cli-glossary.integration.test.ts

@@ -42,9 +42,9 @@ describe('Glossary CLI Integration', () => {
         // Ignore if already cleared
       }
 
+      expect.assertions(1);
       try {
         runCLI('deepl glossary list', { stdio: 'pipe' });
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         // Should indicate API key is required
@@ -113,7 +113,6 @@ describe('Glossary CLI Integration', () => {
         runCLI(`deepl glossary create "Test" en es "${csvFile}"`, {
           stdio: 'pipe',
         });
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         // Should not fail on file format

tests/integration/cli-hooks.integration.test.ts

@@ -155,7 +155,6 @@ describe('Git Hooks Service Integration', () => {
 
     it('should not throw error when uninstalling non-existent hook', () => {
       hooksService.uninstall('post-commit'); // Not installed
-      expect(true).toBe(true); // Test passes without error
     });
 
     it('should throw error when uninstalling non-DeepL hook', () => {

tests/integration/cli-style-rules.integration.test.ts

@@ -52,31 +52,31 @@ describe('Style Rules CLI Integration', () => {
     });
 
     it('should require API key for style-rules list', () => {
+      expect.assertions(1);
       try {
         runCLI('deepl style-rules list', { stdio: 'pipe' });
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).toMatch(/API key|auth|not set/i);
       }
     });
 
     it('should require API key for style-rules list --detailed', () => {
+      expect.assertions(1);
       try {
         runCLI('deepl style-rules list --detailed', { stdio: 'pipe' });
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).toMatch(/API key|auth|not set/i);
       }
     });
 
     it('should require API key for style-rules list with pagination', () => {
+      expect.assertions(1);
       try {
         runCLI('deepl style-rules list --page 1 --page-size 10', {
           stdio: 'pipe',
         });
-        expect(true).toBe(true);
       } catch (error: any) {
         const output = error.stderr ?? error.stdout;
         expect(output).toMatch(/API key|auth|not set/i);