Skip to content

Commit b0526ec

Browse files
test: Default formality is automatic and not always formal
1 parent ed5b7d4 commit b0526ec

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

tests/translateDocument.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,14 @@ describe('translate document', () => {
144144
expect(fs.readFileSync(outputDocumentPath).toString()).toContain('Ihnen');
145145
await unlinkP(outputDocumentPath);
146146

147+
// Default formality is automatic, so the output may be either formal or informal
147148
await translator.translateDocument(exampleDocument, outputDocumentPath, null, 'de', {
148149
formality: 'default',
149150
});
150-
expect(fs.readFileSync(outputDocumentPath).toString()).toContain('Ihnen');
151+
const defaultDocResult = fs.readFileSync(outputDocumentPath).toString();
152+
expect(defaultDocResult.includes('Ihnen') || defaultDocResult.includes('dir')).toBe(
153+
true,
154+
);
151155
await unlinkP(outputDocumentPath);
152156

153157
await translator.translateDocument(exampleDocument, outputDocumentPath, null, 'de', {

tests/translateText.test.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,18 @@ describe('translate text', () => {
119119
const input = 'How are you?';
120120
const formal = 'Ihnen'; // Wie geht es Ihnen?
121121
const informal = 'dir'; // Wie geht es dir?
122-
expect((await translator.translateText(input, null, 'de')).text).toContain(formal);
122+
// Default formality is automatic, so the output may be either formal or informal
123+
const defaultResult = (await translator.translateText(input, null, 'de')).text;
124+
expect(defaultResult.includes(formal) || defaultResult.includes(informal)).toBe(true);
123125
expect(
124126
(await translator.translateText(input, null, 'de', { formality: 'less' })).text,
125127
).toContain(informal);
128+
const defaultExplicitResult = (
129+
await translator.translateText(input, null, 'de', { formality: 'default' })
130+
).text;
126131
expect(
127-
(await translator.translateText(input, null, 'de', { formality: 'default' })).text,
128-
).toContain(formal);
132+
defaultExplicitResult.includes(formal) || defaultExplicitResult.includes(informal),
133+
).toBe(true);
129134
expect(
130135
(await translator.translateText(input, null, 'de', { formality: 'more' })).text,
131136
).toContain(formal);
@@ -137,10 +142,13 @@ describe('translate text', () => {
137142
).toContain(informal);
138143

139144
const formalityDefault = <deepl.Formality>'DEFAULT'; // Type cast to silence type-checks
145+
const formalityDefaultResult = (
146+
await translator.translateText(input, null, 'de', { formality: formalityDefault })
147+
).text;
140148
expect(
141-
(await translator.translateText(input, null, 'de', { formality: formalityDefault }))
142-
.text,
143-
).toContain(formal);
149+
formalityDefaultResult.includes(formal) ||
150+
formalityDefaultResult.includes(informal),
151+
).toBe(true);
144152

145153
const formalityMore = <deepl.Formality>'MORE'; // Type cast to silence type-checks
146154
expect(

0 commit comments

Comments
 (0)