Skip to content

Commit 5c9dea1

Browse files
fix: change formality tests to look for text containing "dir" or "Ihnen" for German formality, rather than depending on exact translation
1 parent 48f94f8 commit 5c9dea1

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

tests/TranslateDocumentTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public function testTranslateDocumentFormality(?ClientInterface $httpClient)
7979
'de',
8080
[TranslateDocumentOptions::FORMALITY => 'more']
8181
);
82-
$this->assertEquals('Wie geht es Ihnen?', $this->readFile($outputDocumentPath));
82+
// Wie geht es Ihnen? uses the formal "Ihnen"
83+
$this->assertStringContainsString('Ihnen', $this->readFile($outputDocumentPath));
8384

8485
unlink($outputDocumentPath);
8586
$translator->translateDocument(
@@ -89,7 +90,8 @@ public function testTranslateDocumentFormality(?ClientInterface $httpClient)
8990
'de',
9091
[TranslateDocumentOptions::FORMALITY => 'less']
9192
);
92-
$this->assertEquals('Wie geht es dir?', $this->readFile($outputDocumentPath));
93+
// Wie geht es dir? uses the informal "dir"
94+
$this->assertStringContainsString('dir', $this->readFile($outputDocumentPath));
9395
}
9496

9597
/**

tests/TranslateTextTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -207,51 +207,51 @@ public function testFormality(?ClientInterface $httpClient)
207207
$this->needsRealServer();
208208
$translator = $this->makeTranslator([TranslatorOptions::HTTP_CLIENT => $httpClient]);
209209
$input = 'How are you?';
210-
$formal = 'Wie geht es Ihnen?';
211-
$informal = 'Wie geht es dir?';
210+
$formal = 'Ihnen'; // Wie geht es Ihnen?
211+
$informal = 'dir'; // Wie geht es dir?
212212
213-
$this->assertEquals($formal, $translator->translateText($input, null, 'de')->text);
214-
$this->assertEquals($informal, $translator->translateText(
213+
$this->assertStringContainsString($formal, $translator->translateText($input, null, 'de')->text);
214+
$this->assertStringContainsString($informal, $translator->translateText(
215215
$input,
216216
null,
217217
'de',
218218
[TranslateTextOptions::FORMALITY => 'less']
219219
)->text);
220-
$this->assertEquals($formal, $translator->translateText(
220+
$this->assertStringContainsString($formal, $translator->translateText(
221221
$input,
222222
null,
223223
'de',
224224
[TranslateTextOptions::FORMALITY => 'default']
225225
)->text);
226-
$this->assertEquals($formal, $translator->translateText(
226+
$this->assertStringContainsString($formal, $translator->translateText(
227227
$input,
228228
null,
229229
'de',
230230
[TranslateTextOptions::FORMALITY => 'more']
231231
)->text);
232232

233233
// Case-insensitive tests
234-
$this->assertEquals($informal, $translator->translateText(
234+
$this->assertStringContainsString($informal, $translator->translateText(
235235
$input,
236236
null,
237237
'de',
238238
[TranslateTextOptions::FORMALITY => 'Less']
239239
)->text);
240-
$this->assertEquals($formal, $translator->translateText(
240+
$this->assertStringContainsString($formal, $translator->translateText(
241241
$input,
242242
null,
243243
'de',
244244
[TranslateTextOptions::FORMALITY => 'MORE']
245245
)->text);
246246

247247
// prefer_* tests
248-
$this->assertEquals($informal, $translator->translateText(
248+
$this->assertStringContainsString($informal, $translator->translateText(
249249
$input,
250250
null,
251251
'de',
252252
[TranslateTextOptions::FORMALITY => 'prefer_less']
253253
)->text);
254-
$this->assertEquals($formal, $translator->translateText(
254+
$this->assertStringContainsString($formal, $translator->translateText(
255255
$input,
256256
null,
257257
'de',

0 commit comments

Comments
 (0)