Test fixes:

- change one test to mock-server only,
- translate example text in to-English direction,
- remove overly brittle test assertions

Author: daniel-jones-dev

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Removed
 ### Fixed
 * Fix bug in CLI languages command causing some target languages to be omitted.
+* Fix some tests that intermittently failed. 
 ### Security
 
 

tests/test_glossary.py

@@ -44,14 +44,6 @@ def test_glossary_create_invalid(
     try:
         with pytest.raises(ValueError):
             translator.create_glossary("", "EN", "DE", {"Hello": "Hallo"})
-        with pytest.raises(deepl.DeepLException):
-            translator.create_glossary(
-                glossary_name, "EN", "JA", {"Hello": "Hallo"}
-            )
-        with pytest.raises(deepl.DeepLException):
-            translator.create_glossary(
-                glossary_name, "JA", "DE", {"Hello": "Hallo"}
-            )
         with pytest.raises(deepl.DeepLException):
             translator.create_glossary(
                 glossary_name, "EN", "XX", {"Hello": "Hallo"}

tests/test_translate_document.py

@@ -145,6 +145,7 @@ def test_invalid_document(translator, tmpdir):
         )
 
 
+@needs_mock_server
 def test_translate_document_low_level(
     translator,
     example_document_path,
@@ -153,7 +154,6 @@ def test_translate_document_low_level(
     server,
 ):
     # Set a small document queue time to attempt downloading a queued document
-    # Note: this is a noop unless using a mock-server
     server.set_doc_queue_time(100)
 
     with open(example_document_path, "rb") as infile:

tests/test_translate_text.py

@@ -335,22 +335,22 @@ def test_empty_text(translator):
 
 
 def test_mixed_case_languages(translator):
-    result = translator.translate_text(example_text["EN"], target_lang="pt-pt")
-    assert example_text["PT-PT"] == result.text
-    assert "EN" == result.detected_source_lang
+    result = translator.translate_text(example_text["DE"], target_lang="en-us")
+    assert example_text["EN-US"] == result.text.lower()
+    assert "DE" == result.detected_source_lang
 
-    result = translator.translate_text(example_text["EN"], target_lang="PT-pt")
-    assert example_text["PT-PT"] == result.text
-    assert "EN" == result.detected_source_lang
+    result = translator.translate_text(example_text["DE"], target_lang="EN-us")
+    assert example_text["EN-US"] == result.text.lower()
+    assert "DE" == result.detected_source_lang
 
     result = translator.translate_text(
-        example_text["EN"], source_lang="en", target_lang="PT-PT"
+        example_text["DE"], source_lang="de", target_lang="EN-US"
     )
-    assert example_text["PT-PT"] == result.text
-    assert "EN" == result.detected_source_lang
+    assert example_text["EN-US"] == result.text.lower()
+    assert "DE" == result.detected_source_lang
 
     result = translator.translate_text(
-        example_text["EN"], source_lang="eN", target_lang="PT-PT"
+        example_text["DE"], source_lang="dE", target_lang="EN-US"
     )
-    assert example_text["PT-PT"] == result.text
-    assert "EN" == result.detected_source_lang
+    assert example_text["EN-US"] == result.text.lower()
+    assert "DE" == result.detected_source_lang