Extract initClientAndConfig from issues Run method

- Pull config loading and client creation into a separate helper
- Silence unused-parameter lint warnings in test files

Author: jai-deepsource

command/cmdutil/resolve_run_test.go

@@ -472,7 +472,7 @@ func TestResolveWithPR_PendingNoCompletedRuns(t *testing.T) {
 
 	callCount := 0
 	mock := graphqlclient.NewMockClient()
-	mock.QueryFunc = func(_ context.Context, query string, _ map[string]any, result any) error {
+	mock.QueryFunc = func(_ context.Context, _ string, _ map[string]any, result any) error {
 		callCount++
 		if callCount == 1 {
 			return json.Unmarshal(pendingData, result)

command/issues/issues.go

@@ -215,7 +215,7 @@ func flagUsageLine(f *pflag.Flag) string {
 	return line
 }
 
-func (opts *IssuesOptions) Run(ctx context.Context) error {
+func (opts *IssuesOptions) initClientAndConfig() (*deepsource.Client, *vcs.RemoteData, error) {
 	var cfgMgr *config.Manager
 	if opts.deps != nil && opts.deps.ConfigMgr != nil {
 		cfgMgr = opts.deps.ConfigMgr
@@ -224,30 +224,36 @@ func (opts *IssuesOptions) Run(ctx context.Context) error {
 	}
 	cfg, err := cfgMgr.Load()
 	if err != nil {
-		return clierrors.NewCLIError(clierrors.ErrInvalidConfig, "Error reading DeepSource CLI config", err)
+		return nil, nil, clierrors.NewCLIError(clierrors.ErrInvalidConfig, "Error reading DeepSource CLI config", err)
 	}
 	if err := cfg.VerifyAuthentication(); err != nil {
-		return err
+		return nil, nil, err
 	}
 
 	remote, err := vcs.ResolveRemote(opts.RepoArg)
 	if err != nil {
-		return err
+		return nil, nil, err
 	}
 	opts.repoSlug = remote.Owner + "/" + remote.RepoName
 
-	var client *deepsource.Client
 	if opts.deps != nil && opts.deps.Client != nil {
-		client = opts.deps.Client
-	} else {
-		client, err = deepsource.New(deepsource.ClientOpts{
-			Token:            cfg.Token,
-			HostName:         cfg.Host,
-			OnTokenRefreshed: cfgMgr.TokenRefreshCallback(),
-		})
-		if err != nil {
-			return err
-		}
+		return opts.deps.Client, remote, nil
+	}
+	client, err := deepsource.New(deepsource.ClientOpts{
+		Token:            cfg.Token,
+		HostName:         cfg.Host,
+		OnTokenRefreshed: cfgMgr.TokenRefreshCallback(),
+	})
+	if err != nil {
+		return nil, nil, err
+	}
+	return client, remote, nil
+}
+
+func (opts *IssuesOptions) Run(ctx context.Context) error {
+	client, remote, err := opts.initClientAndConfig()
+	if err != nil {
+		return err
 	}
 
 	if opts.CommitOid != "" {

command/issues/tests/issues_test.go

@@ -806,7 +806,7 @@ func TestIssuesPaginationHardCap(t *testing.T) {
 
 	mock := graphqlclient.NewMockClient()
 	callCount := 0
-	mock.QueryFunc = func(_ context.Context, query string, _ map[string]any, result any) error {
+	mock.QueryFunc = func(_ context.Context, _ string, _ map[string]any, result any) error {
 		callCount++
 		return json.Unmarshal(pageJSON, result)
 	}
@@ -876,7 +876,7 @@ func TestIssuesPaginationHardCapWarning(t *testing.T) {
 }`)
 
 	mock := graphqlclient.NewMockClient()
-	mock.QueryFunc = func(_ context.Context, query string, vars map[string]any, result any) error {
+	mock.QueryFunc = func(_ context.Context, _ string, _ map[string]any, result any) error {
 		return json.Unmarshal(pageJSON, result)
 	}
 	client := deepsource.NewWithGraphQLClient(mock)

deepsource/graphqlclient/transport_test.go

@@ -154,7 +154,7 @@ func TestSetAuthToken(t *testing.T) {
 func TestMockClient_QueryDelegation(t *testing.T) {
 	called := false
 	mock := NewMockClient()
-	mock.QueryFunc = func(ctx context.Context, query string, vars map[string]any, result any) error {
+	mock.QueryFunc = func(_ context.Context, query string, _ map[string]any, _ any) error {
 		called = true
 		if query != "{ viewer }" {
 			t.Errorf("query = %q, want %q", query, "{ viewer }")
@@ -174,7 +174,7 @@ func TestMockClient_QueryDelegation(t *testing.T) {
 func TestMockClient_MutateDelegation(t *testing.T) {
 	wantErr := errors.New("mutation failed")
 	mock := NewMockClient()
-	mock.MutateFunc = func(ctx context.Context, mutation string, vars map[string]any, result any) error {
+	mock.MutateFunc = func(_ context.Context, _ string, _ map[string]any, _ any) error {
 		return wantErr
 	}