Skip to content

Commit 7170740

Browse files
Fix test assertions to match actual error strings
- Update report golden file with info-level progress lines - Fix case mismatches in OIDC tests (failed -> Failed, can not -> cannot, provider -> Provider)
1 parent 2b1e881 commit 7170740

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

internal/oidc/fetch_oidc_token_test.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func TestFetchOIDCTokenFromProvider(t *testing.T) {
6363
if err == nil {
6464
t.Fatal("Expected error for non-200 status, got nil")
6565
}
66-
expectedErrorMsg := "failed to fetch OIDC token: 404 Not Found"
66+
expectedErrorMsg := "Failed to fetch OIDC token: 404 Not Found"
6767
if !strings.Contains(err.Error(), expectedErrorMsg) {
6868
t.Errorf("Expected error message to contain '%s', got '%s'", expectedErrorMsg, err.Error())
6969
}
@@ -145,7 +145,7 @@ func TestExchangeOIDCTokenForTempDSN(t *testing.T) {
145145
if err == nil {
146146
t.Fatal("Expected error for non-200 status, got nil")
147147
}
148-
expectedErrorMsg := "failed to exchange OIDC token for DSN: 403 Forbidden"
148+
expectedErrorMsg := "Failed to exchange OIDC token for DSN: 403 Forbidden"
149149
if !strings.Contains(err.Error(), expectedErrorMsg) {
150150
t.Errorf("Expected error message to contain '%s', got '%s'", expectedErrorMsg, err.Error())
151151
}
@@ -252,7 +252,7 @@ func TestGetDSNFromOIDC(t *testing.T) {
252252
if err == nil {
253253
t.Fatal("Expected error for empty dsEndpoint, got nil")
254254
}
255-
if !strings.Contains(err.Error(), "--deepsource-host-endpoint can not be empty") {
255+
if !strings.Contains(err.Error(), "--deepsource-host-endpoint cannot be empty") {
256256
t.Errorf("Unexpected error message: %s", err.Error())
257257
}
258258
})
@@ -264,7 +264,7 @@ func TestGetDSNFromOIDC(t *testing.T) {
264264
if err == nil {
265265
t.Fatal("Expected error for empty provider, got nil")
266266
}
267-
if !strings.Contains(err.Error(), "--oidc-provider can not be empty") {
267+
if !strings.Contains(err.Error(), "--oidc-provider cannot be empty") {
268268
t.Errorf("Unexpected error message: %s", err.Error())
269269
}
270270
})
@@ -275,8 +275,8 @@ func TestGetDSNFromOIDC(t *testing.T) {
275275
if err == nil {
276276
t.Fatal("Expected error for unsupported provider, got nil")
277277
}
278-
if !strings.Contains(err.Error(), "provider unsupported is not supported") {
279-
t.Errorf("Expected error message to contain 'provider unsupported is not supported', got '%s'", err.Error())
278+
if !strings.Contains(err.Error(), "Provider unsupported is not supported") {
279+
t.Errorf("Expected error message to contain 'Provider unsupported is not supported', got '%s'", err.Error())
280280
}
281281
})
282282

@@ -294,7 +294,7 @@ func TestGetDSNFromOIDC(t *testing.T) {
294294
if err == nil {
295295
t.Fatal("Expected error for missing ACTIONS_ID_TOKEN_REQUEST_TOKEN, got nil")
296296
}
297-
if !strings.Contains(err.Error(), `failed to fetch "ACTIONS_ID_TOKEN_REQUEST_TOKEN"`) {
297+
if !strings.Contains(err.Error(), `Failed to fetch "ACTIONS_ID_TOKEN_REQUEST_TOKEN"`) {
298298
t.Errorf("Unexpected error message: %s", err.Error())
299299
}
300300
})
@@ -312,7 +312,7 @@ func TestGetDSNFromOIDC(t *testing.T) {
312312
if err == nil {
313313
t.Fatal("Expected error for missing ACTIONS_ID_TOKEN_REQUEST_URL, got nil")
314314
}
315-
if !strings.Contains(err.Error(), `failed to fetch "ACTIONS_ID_TOKEN_REQUEST_TOKEN"`) { // Error message covers both
315+
if !strings.Contains(err.Error(), `Failed to fetch "ACTIONS_ID_TOKEN_REQUEST_TOKEN"`) { // Error message covers both
316316
t.Errorf("Unexpected error message: %s", err.Error())
317317
}
318318
})
@@ -327,7 +327,7 @@ func TestGetDSNFromOIDC(t *testing.T) {
327327
if err == nil {
328328
t.Fatal("Expected error when FetchOIDCTokenFromProvider fails, got nil")
329329
}
330-
if !strings.Contains(err.Error(), "failed to fetch OIDC token") {
330+
if !strings.Contains(err.Error(), "Failed to fetch OIDC token") {
331331
t.Errorf("Unexpected error message: %s", err.Error())
332332
}
333333
})
@@ -342,7 +342,7 @@ func TestGetDSNFromOIDC(t *testing.T) {
342342
if err == nil {
343343
t.Fatal("Expected error when ExchangeOIDCTokenForTempDSN fails, got nil")
344344
}
345-
if !strings.Contains(err.Error(), "failed to exchange OIDC token for DSN") {
345+
if !strings.Contains(err.Error(), "Failed to exchange OIDC token for DSN") {
346346
t.Errorf("Unexpected error message: %s", err.Error())
347347
}
348348
})

0 commit comments

Comments
 (0)