|
1 | 1 | package config |
2 | 2 |
|
3 | 3 | import ( |
| 4 | + "os" |
| 5 | + "path/filepath" |
4 | 6 | "testing" |
5 | 7 |
|
| 8 | + "github.com/deepsourcelabs/cli/buildinfo" |
6 | 9 | "github.com/deepsourcelabs/cli/internal/adapters" |
7 | 10 | "github.com/deepsourcelabs/cli/internal/secrets" |
| 11 | + "github.com/pelletier/go-toml" |
8 | 12 | "github.com/stretchr/testify/assert" |
| 13 | + "github.com/stretchr/testify/require" |
9 | 14 | ) |
10 | 15 |
|
11 | 16 | type fakeSecretStore struct { |
@@ -40,3 +45,151 @@ func TestManagerLoadTokenFromSecrets(t *testing.T) { |
40 | 45 | assert.NoError(t, err) |
41 | 46 | assert.Equal(t, "secret-token", cfg.Token) |
42 | 47 | } |
| 48 | + |
| 49 | +func TestManagerLoadFromFile(t *testing.T) { |
| 50 | + tempDir := t.TempDir() |
| 51 | + homeDir := func() (string, error) { return tempDir, nil } |
| 52 | + |
| 53 | + configDir := filepath.Join(tempDir, buildinfo.ConfigDirName) |
| 54 | + require.NoError(t, os.MkdirAll(configDir, 0o700)) |
| 55 | + |
| 56 | + tomlData := `host = "app.deepsource.io" |
| 57 | +user = "alice" |
| 58 | +token = "file-token" |
| 59 | +` |
| 60 | + require.NoError(t, os.WriteFile(filepath.Join(configDir, ConfigFileName), []byte(tomlData), 0o644)) |
| 61 | + |
| 62 | + mgr := NewManager(adapters.NewOSFileSystem(), homeDir) |
| 63 | + cfg, err := mgr.Load() |
| 64 | + require.NoError(t, err) |
| 65 | + assert.Equal(t, "app.deepsource.io", cfg.Host) |
| 66 | + assert.Equal(t, "alice", cfg.User) |
| 67 | + assert.Equal(t, "file-token", cfg.Token) |
| 68 | +} |
| 69 | + |
| 70 | +func TestManagerLoadNoFile(t *testing.T) { |
| 71 | + tempDir := t.TempDir() |
| 72 | + homeDir := func() (string, error) { return tempDir, nil } |
| 73 | + |
| 74 | + mgr := NewManager(adapters.NewOSFileSystem(), homeDir) |
| 75 | + cfg, err := mgr.Load() |
| 76 | + require.NoError(t, err) |
| 77 | + assert.Empty(t, cfg.Host) |
| 78 | + assert.Empty(t, cfg.User) |
| 79 | + assert.Empty(t, cfg.Token) |
| 80 | +} |
| 81 | + |
| 82 | +func TestManagerWrite(t *testing.T) { |
| 83 | + tempDir := t.TempDir() |
| 84 | + homeDir := func() (string, error) { return tempDir, nil } |
| 85 | + |
| 86 | + // Use NoopStore so token stays in the TOML file |
| 87 | + mgr := NewManager(adapters.NewOSFileSystem(), homeDir) |
| 88 | + err := mgr.Write(&CLIConfig{ |
| 89 | + Host: "example.com", |
| 90 | + User: "bob", |
| 91 | + }) |
| 92 | + require.NoError(t, err) |
| 93 | + |
| 94 | + // Read back the raw TOML |
| 95 | + path := filepath.Join(tempDir, buildinfo.ConfigDirName, ConfigFileName) |
| 96 | + data, err := os.ReadFile(path) |
| 97 | + require.NoError(t, err) |
| 98 | + |
| 99 | + var got CLIConfig |
| 100 | + require.NoError(t, toml.Unmarshal(data, &got)) |
| 101 | + assert.Equal(t, "example.com", got.Host) |
| 102 | + assert.Equal(t, "bob", got.User) |
| 103 | +} |
| 104 | + |
| 105 | +func TestManagerWriteStoresTokenInSecrets(t *testing.T) { |
| 106 | + tempDir := t.TempDir() |
| 107 | + homeDir := func() (string, error) { return tempDir, nil } |
| 108 | + store := &fakeSecretStore{data: make(map[string]string)} |
| 109 | + |
| 110 | + mgr := NewManagerWithSecrets(adapters.NewOSFileSystem(), homeDir, store, "mykey") |
| 111 | + err := mgr.Write(&CLIConfig{ |
| 112 | + Host: "example.com", |
| 113 | + Token: "super-secret", |
| 114 | + }) |
| 115 | + require.NoError(t, err) |
| 116 | + |
| 117 | + // Token should be in secret store |
| 118 | + assert.Equal(t, "super-secret", store.data["mykey"]) |
| 119 | + |
| 120 | + // Token should NOT be in the TOML file |
| 121 | + path := filepath.Join(tempDir, buildinfo.ConfigDirName, ConfigFileName) |
| 122 | + data, err := os.ReadFile(path) |
| 123 | + require.NoError(t, err) |
| 124 | + |
| 125 | + var got CLIConfig |
| 126 | + require.NoError(t, toml.Unmarshal(data, &got)) |
| 127 | + assert.Empty(t, got.Token, "token should not be written to TOML when secret store succeeds") |
| 128 | +} |
| 129 | + |
| 130 | +func TestManagerDelete(t *testing.T) { |
| 131 | + tempDir := t.TempDir() |
| 132 | + homeDir := func() (string, error) { return tempDir, nil } |
| 133 | + store := &fakeSecretStore{data: map[string]string{"mykey": "tok"}} |
| 134 | + |
| 135 | + mgr := NewManagerWithSecrets(adapters.NewOSFileSystem(), homeDir, store, "mykey") |
| 136 | + |
| 137 | + // Write a config first |
| 138 | + require.NoError(t, mgr.Write(&CLIConfig{Host: "example.com", Token: "tok"})) |
| 139 | + |
| 140 | + // Delete it |
| 141 | + require.NoError(t, mgr.Delete()) |
| 142 | + |
| 143 | + // File should be gone |
| 144 | + path := filepath.Join(tempDir, buildinfo.ConfigDirName, ConfigFileName) |
| 145 | + _, err := os.Stat(path) |
| 146 | + assert.True(t, os.IsNotExist(err), "config file should be deleted") |
| 147 | + |
| 148 | + // Secret should be gone |
| 149 | + _, ok := store.data["mykey"] |
| 150 | + assert.False(t, ok, "secret should be deleted") |
| 151 | +} |
| 152 | + |
| 153 | +func TestManagerDeleteNonExistent(t *testing.T) { |
| 154 | + tempDir := t.TempDir() |
| 155 | + homeDir := func() (string, error) { return tempDir, nil } |
| 156 | + |
| 157 | + mgr := NewManager(adapters.NewOSFileSystem(), homeDir) |
| 158 | + err := mgr.Delete() |
| 159 | + assert.NoError(t, err, "deleting non-existent config should not error") |
| 160 | +} |
| 161 | + |
| 162 | +func TestManagerTokenRefreshCallback(t *testing.T) { |
| 163 | + tempDir := t.TempDir() |
| 164 | + homeDir := func() (string, error) { return tempDir, nil } |
| 165 | + store := &fakeSecretStore{data: make(map[string]string)} |
| 166 | + |
| 167 | + mgr := NewManagerWithSecrets(adapters.NewOSFileSystem(), homeDir, store, "key") |
| 168 | + |
| 169 | + // Write initial config |
| 170 | + require.NoError(t, mgr.Write(&CLIConfig{Host: "example.com", User: "old@test.com", Token: "old-token"})) |
| 171 | + |
| 172 | + // Invoke the refresh callback |
| 173 | + cb := mgr.TokenRefreshCallback() |
| 174 | + cb("new-token", "2030-01-01T00:00:00Z", "new@test.com") |
| 175 | + |
| 176 | + // Reload and verify |
| 177 | + cfg, err := mgr.Load() |
| 178 | + require.NoError(t, err) |
| 179 | + assert.Equal(t, "new-token", cfg.Token) |
| 180 | + assert.Equal(t, "new@test.com", cfg.User) |
| 181 | + assert.False(t, cfg.TokenExpiresIn.IsZero(), "token expiry should be set") |
| 182 | +} |
| 183 | + |
| 184 | +func TestNewManagerDefaults(t *testing.T) { |
| 185 | + homeDir := func() (string, error) { return "/tmp", nil } |
| 186 | + |
| 187 | + // NewManager uses NoopStore |
| 188 | + mgr := NewManager(adapters.NewOSFileSystem(), homeDir) |
| 189 | + assert.NotNil(t, mgr) |
| 190 | + |
| 191 | + // nil store defaults to NoopStore, empty key defaults to KeychainKey |
| 192 | + mgr2 := NewManagerWithSecrets(adapters.NewOSFileSystem(), homeDir, nil, "") |
| 193 | + assert.NotNil(t, mgr2) |
| 194 | + assert.Equal(t, buildinfo.KeychainKey, mgr2.secretsKey) |
| 195 | +} |
0 commit comments