Remove incorrect await from synchronous fs functions#2659
Closed
ryantsou wants to merge 1 commit intoDeepSourceCorp:masterfrom
Closed
Remove incorrect await from synchronous fs functions#2659ryantsou wants to merge 1 commit intoDeepSourceCorp:masterfrom
ryantsou wants to merge 1 commit intoDeepSourceCorp:masterfrom
Conversation
The await keyword should not be used with fs.statSync() and fs.readFileSync() as these are synchronous functions that do not return Promises. This was causing unnecessary awaits in the code.
|
@ryantsou is attempting to deploy a commit to the DeepSource Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Closing. This change was not requested and does not address an open issue. Please only submit PRs for work that has been discussed with maintainers or addresses an existing issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes incorrect await keywords from synchronous file system operations in sync.js.
The await keyword should not be used with fs.statSync() and fs.readFileSync() as these are synchronous functions that do not return Promises.
Changes: