Handle new changes to site 2025-12#128
Merged
Merged
Conversation
These should still be handled by `to_iso8601()` inside the actual application, that uses `Time.parse()` and is a bit more flexible. Maybe the test is too strict tbh, but hey
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… be a tag instead
…ission has an additional keyword
…or backwards compatibility, let's just subtract one when making the request. (I know, it seems a little horrible, but this application is full of horrible things done for backwards compatibility)
…dexed. For backwards compatibility, let's just subtract one when making the request. (I know, it seems a little horrible, but this application is full of horrible things done for backwards compatibility)" This reverts commit 58c9e96. Turns out they're not 0-indexed now. There's just some weirdness with empty watcher lists
…hat page 1 displays the same as the default page if there are no watchers
…ader" test as skipped, as this is a known and reported FA bug
Deer-Spangle
changed the title
…sults come back in the search. Also, validate one search before making a second search, to fail faster without hitting FA so much.
… params like `do_search` and `next_page`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's been a few changes to the site lately, as the devs have been busy! And so, we have a list of tweaks needed here:
pageis actually set to1rather than left blank