handleMfaStartError helper

Author: j-chmielewski

new-ui/src/shared/components/LocationCard/hooks/handleMfaStartError.ts

@@ -0,0 +1,25 @@
+import type { LocationInfo } from '../../../rust-api/types';
+import { shouldShowPostureError } from '../api/startClientMfaSession';
+import { LocationCardViews, type LocationCardViewsValue } from '../context/types';
+
+type HandleMfaStartErrorParams = {
+  err: unknown;
+  location: LocationInfo;
+  setPostureError: (error: string | null) => void;
+  setView: (view: LocationCardViewsValue) => void;
+};
+
+export const handleMfaStartError = ({
+  err,
+  location,
+  setPostureError,
+  setView,
+}: HandleMfaStartErrorParams): boolean => {
+  if (!shouldShowPostureError(err, location)) {
+    return false;
+  }
+
+  setPostureError(err.message);
+  setView(LocationCardViews.PostureCheckFail);
+  return true;
+};

new-ui/src/shared/components/LocationCard/hooks/useMfaConnect.ts

@@ -5,13 +5,10 @@ import { useCallback, useEffect, useRef, useState } from 'react';
 import { api } from '../../../rust-api/api';
 import { getInstancesQueryOptions } from '../../../rust-api/query';
 import type { EdgeRequestHeaders } from '../../../rust-api/types';
-import {
-  CLIENT_MFA_ENDPOINT,
-  shouldShowPostureError,
-  startClientMfaSession,
-} from '../api/startClientMfaSession';
+import { CLIENT_MFA_ENDPOINT, startClientMfaSession } from '../api/startClientMfaSession';
 import { useLocationCardContext } from '../context/context';
 import { LocationCardViews } from '../context/types';
+import { handleMfaStartError } from './handleMfaStartError';
 
 type MfaFinishResponse = {
   preshared_key: string;
@@ -66,9 +63,7 @@ export const useMfaConnect = (method: 0 | 1) => {
         setRequestHeaders(headers);
         setToken(response.token);
       } catch (err) {
-        if (shouldShowPostureError(err, location)) {
-          setPostureError(err.message);
-          setView(LocationCardViews.PostureCheckFail);
+        if (handleMfaStartError({ err, location, setPostureError, setView })) {
           return;
         }
         setStartError(err instanceof Error ? err.message : 'Failed to start MFA');

new-ui/src/shared/components/LocationCard/hooks/useMfaMobileConnect.ts

@@ -3,13 +3,10 @@ import { useMutation } from '@tanstack/react-query';
 import { error } from '@tauri-apps/plugin-log';
 import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { api } from '../../../rust-api/api';
-import {
-  CLIENT_MFA_ENDPOINT,
-  shouldShowPostureError,
-  startClientMfaSession,
-} from '../api/startClientMfaSession';
+import { CLIENT_MFA_ENDPOINT, startClientMfaSession } from '../api/startClientMfaSession';
 import { useLocationCardContext } from '../context/context';
 import { LocationCardViews } from '../context/types';
+import { handleMfaStartError } from './handleMfaStartError';
 
 type TokenData = {
   token: string;
@@ -150,9 +147,7 @@ export const useMfaMobileConnect = () => {
 
       setTokenData({ token: response.token, challenge: response.challenge });
     } catch (e) {
-      if (shouldShowPostureError(e, location)) {
-        setPostureError(e.message);
-        setView(LocationCardViews.PostureCheckFail);
+      if (handleMfaStartError({ err: e, location, setPostureError, setView })) {
         return;
       }
       setStartError(

new-ui/src/shared/components/LocationCard/hooks/useMfaOidcConnect.ts

@@ -4,13 +4,10 @@ import { error } from '@tauri-apps/plugin-log';
 import { useCallback, useEffect, useRef, useState } from 'react';
 import { api } from '../../../rust-api/api';
 import { getInstancesQueryOptions } from '../../../rust-api/query';
-import {
-  CLIENT_MFA_ENDPOINT,
-  shouldShowPostureError,
-  startClientMfaSession,
-} from '../api/startClientMfaSession';
+import { CLIENT_MFA_ENDPOINT, startClientMfaSession } from '../api/startClientMfaSession';
 import { useLocationCardContext } from '../context/context';
 import { LocationCardViews } from '../context/types';
+import { handleMfaStartError } from './handleMfaStartError';
 
 const POLL_INTERVAL_MS = 5_000;
 const POLL_TIMEOUT_MS = 5 * 60 * 1_000; // 5 minutes
@@ -140,9 +137,7 @@ export const useMfaOidcConnect = () => {
       await api.openLink(`${instance.proxy_url}openid/mfa?token=${response.token}`);
       startPolling(response.token, instance.proxy_url, headers);
     } catch (e) {
-      if (shouldShowPostureError(e, location)) {
-        setPostureError(e.message);
-        setView(LocationCardViews.PostureCheckFail);
+      if (handleMfaStartError({ err: e, location, setPostureError, setView })) {
         return;
       }
       setStartError(