Apply suggestions from code review

DenysMoskalenko · valentijnscholten · DenysMoskalenko · commit 34b4bb1f33ae · 2025-06-25T15:08:17.000+02:00
Fix typo in the "build_count_subquery" docstring

Co-authored-by: valentijnscholten &lt;valentijnscholten@gmail.com&gt;
diff --git a/dojo/utils.py b/dojo/utils.py
@@ -2674,8 +2674,8 @@ def parse_cvss_data(cvss_vector_string: str) -> dict:
 
 
 def build_count_subquery(model_qs: QuerySet, group_field: str) -> Subquery:
-    """Return a Subquery that yields one aggregated count per test_id."""
+    """Return a Subquery that yields one aggregated count per `group_field`."""
     return Subquery(
-        model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1],  # one row per test_id
+        model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1],  # one row per group_field
         output_field=IntegerField(),
     )

Original file line number	Diff line number	Diff line change
`@@ -2674,8 +2674,8 @@ def parse_cvss_data(cvss_vector_string: str) -> dict:`
`2674`	`2674`
`2675`	`2675`
`2676`	`2676`	`def build_count_subquery(model_qs: QuerySet, group_field: str) -> Subquery:`
`2677`		`- """Return a Subquery that yields one aggregated count per test_id."""`
	`2677`	+ """Return a Subquery that yields one aggregated count per `group_field`."""
`2678`	`2678`	`return Subquery(`
`2679`		`- model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1], # one row per test_id`
	`2679`	`+ model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1], # one row per group_field`
`2680`	`2680`	`output_field=IntegerField(),`
`2681`	`2681`	`)`