remove TODO; fix scan type name

Author: rl-maartenb

dojo/tools/reversinglabs_spectraassure/parser.py

@@ -9,7 +9,7 @@
 
 logger = logging.getLogger(__name__)
 
-WHAT = "ReversingLabs Spectra Assure"
+SCAN_TYPE = "ReversingLabs Spectra Assure"
 
 
 class ReversinglabsSpectraassureParser:
@@ -72,13 +72,13 @@ def _one_finding(
     # --------------------------------------------
     # PUBLIC
     def get_scan_types(self) -> list[str]:
-        return [WHAT]
+        return [SCAN_TYPE]
 
     def get_label_for_scan_types(self, scan_type: str) -> str:
         return scan_type
 
     def get_description_for_scan_types(self, scan_type: str) -> str:
-        if scan_type == WHAT:
+        if scan_type == SCAN_TYPE:
             return "Import the SpectraAssure report.rl.json file."
         return f"Unknown Scan Type; {scan_type}"
 

dojo/tools/reversinglabs_spectraassure/rlJsonInfo/__init__.py

@@ -340,7 +340,6 @@ def _make_new_cin(
         cin.score = score
         cin.score_severity = self._score_to_severity(score=score)
 
-        # TODO: tags
         cin.tags = self._get_tags_from_cve(this_cve)
         cin.impact = self._make_impact_from_tags(cin.tags, cin.impact)
 
@@ -397,7 +396,7 @@ def _do_one_cve_component_dependency(
 
         # should be constant over multiple re-scans (repeatable)
         # see: https://github.com/DefectDojo/django-DefectDojo/pull/12463
-        # TODO: use component sha256 + dep.name, dep version + cve
+        # use component sha256 + dep.name, dep version + cve
 
         dep_purl = dependency.get("purl", "")
         dep_name = dependency.get("product", "")