Skip to content

Commit 51f9261

Browse files
fix: guard filter snippet include when no form passed to metrics template (#14945)
critical_product_metrics view renders metrics.html without a form context variable. Django resolves undefined template vars as empty string, causing get_filter_groups to crash with AttributeError on str.visible_fields(). Wrapping the filter_snippet include in {% if form %} prevents the crash. Fixes #14944.
1 parent 75e7834 commit 51f9261

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

dojo/templates/dojo/metrics.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,11 @@ <h3 {% if not critical_prods %}class="has-filters" {% endif %}>
147147
</h3>
148148
</div>
149149
</div>
150+
{% if form %}
150151
<div id="the-filters" class="is-filters panel-body collapse">
151152
{% include "dojo/filter_snippet.html" with form=form clear_link="/metrics/product/type" %}
152153
</div>
154+
{% endif %}
153155
</div>
154156
</div>
155157
</div>

dojo/templates_classic/dojo/metrics.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,11 @@ <h3 {% if not critical_prods %}class="has-filters" {% endif %}>
155155
</h3>
156156
</div>
157157
</div>
158+
{% if form %}
158159
<div id="the-filters" class="is-filters panel-body collapse">
159160
{% include "dojo/filter_snippet.html" with form=form clear_link="/metrics/product/type" %}
160161
</div>
162+
{% endif %}
161163
</div>
162164
</div>
163165
</div>

0 commit comments

Comments
 (0)