review

Author: manuel-sommer

dojo/tools/zora/parser.py

@@ -60,6 +60,7 @@ def get_findings(self, content, test: Test) -> list[Finding]:
             )
             if row.get("fixVersion"):
                 finding.fix_available = True
+                finding.fix_version = row.get("fixVersion")
             else:
                 finding.fix_available = False
             vuln_id = row.get("id")

unittests/tools/test_zora_parser.py

@@ -21,12 +21,16 @@ def test_parse_file_with_many_vuln_has_many_findings(self):
             # Check a specific finding for correctness
             finding = findings[0]
             self.assertEqual(True, finding.fix_available)
+            self.assertEqual("1.2.5-r1", finding.fix_version)
             finding = findings[1]
             self.assertEqual(False, finding.fix_available)
+            self.assertEqual(None, finding.fix_version)
             finding = findings[2]
             self.assertEqual(False, finding.fix_available)
+            self.assertEqual(None, finding.fix_version)
             finding = findings[3]
             self.assertEqual(True, finding.fix_available)
+            self.assertEqual("3.3.5-r0", finding.fix_version)
             finding = findings[10]
             self.assertEqual("net/url: Insufficient validation of bracketed IPv6 hostnames in net/url", finding.title)
             self.assertEqual("Medium", finding.severity)