Apply suggestions from code review

DenysMoskalenko · valentijnscholten · web-flow · commit 551ce8ef096a · 2025-06-13T22:03:20.000+02:00
Fix typo in the "build_count_subquery" docstring

Co-authored-by: valentijnscholten &lt;valentijnscholten@gmail.com&gt;
diff --git a/dojo/utils.py b/dojo/utils.py
@@ -2675,8 +2675,8 @@ def tag_validator(value: str | list[str], exception_class: Callable = Validation
 
 
 def build_count_subquery(model_qs: QuerySet, group_field: str) -> Subquery:
-    """Return a Subquery that yields one aggregated count per test_id."""
+    """Return a Subquery that yields one aggregated count per `group_field`."""
     return Subquery(
-        model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1],  # one row per test_id
+        model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1],  # one row per group_field
         output_field=IntegerField(),
     )

Original file line number	Diff line number	Diff line change
`@@ -2675,8 +2675,8 @@ def tag_validator(value: str \| list[str], exception_class: Callable = Validation`
`2675`	`2675`
`2676`	`2676`
`2677`	`2677`	`def build_count_subquery(model_qs: QuerySet, group_field: str) -> Subquery:`
`2678`		`- """Return a Subquery that yields one aggregated count per test_id."""`
	`2678`	+ """Return a Subquery that yields one aggregated count per `group_field`."""
`2679`	`2679`	`return Subquery(`
`2680`		`- model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1], # one row per test_id`
	`2680`	`+ model_qs.values(group_field).annotate(c=Count("*")).values("c")[:1], # one row per group_field`
`2681`	`2681`	`output_field=IntegerField(),`
`2682`	`2682`	`)`